feat: point the official entries at the re-signed detailLinks releases - #1
Merged
Merged
Conversation
Argo CD 0.2.0 and Flux 0.3.0 rename rowActions to detailLinks (srelens/srelens#537) and are signed with the rotated publisher key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Points the official Argo CD and Flux entries at their re-signed releases, which rename
rowActionstodetailLinks(srelens#537, srelens/srelens#598).What
org.srelens.argocd22e3578a76715a2611b557ab74c3a4002cd55ac1d1ff759668799a61076890dborg.srelens.flux777c3afa8b036ffc2976dc3803f712f366f82549434c8d51219054567b7c2085manifestUrl: each entry now points at the new release'smanifest.json.testedHost.revision:5360059, the srelens commit both release workflows validated against (the head of #598 at the time).catalog.json: regenerated withscripts/catalog.py.Why now
EXTENSION_UNKNOWN_FIELD. #598's "live catalog and signatures" check fails until this merges.signing-public.pemand #598'ssrelens-apps.pubhold.Verification
sha256sum -c SHA256SUMSpasses for both downloaded releases, and the entry hashes are taken from those same bytes.manifest.json.sigfiles (64 bytes) verify against the new public key with Node's Ed25519crypto.verify.detailLinksand norowActions.python scripts/catalog.py --checkandpython -m unittest discover -s testspass.Once #598 merges,
testedHost.revisioncan move to the merged commit.