Enable days_previous_auto and prediction_kernel by default#4189
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes Predbat’s defaults to enable the weighted-bucket historical load forecast (days_previous_auto) and the compiled C++ prediction kernel (prediction_kernel_enable) by default, and updates user-facing templates/docs to reflect the new behaviour.
Changes:
- Enable
days_previous_autoby default (switches default load forecasting to the weighted-bucket model). - Enable
prediction_kernel_enableby default (prefers the C++ kernel with automatic fallback to Python if unavailable). - Refresh templates and documentation around
days_previoussemantics, holiday-mode interaction, and kernel enablement.
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/predbat/fetch.py | Switch default values for days_previous_auto and prediction_kernel_enable to True. |
| apps/predbat/tests/test_infra.py | Pins days_previous_auto to False for the general test default config. |
| coverage/apps.yaml | Pins days_previous_auto to False for the broader test suite config. |
| docs/customisation.md | Updates kernel wording (now default-on) and clarifies holiday-mode handling with days_previous_auto. |
| docs/apps-yaml.md | Updates documentation to reflect kernel default-on + fallback, and clarifies days_previous_auto default semantics. |
| apps/predbat/config/apps.yaml | Updates the embedded sample config comments around days_previous. |
| templates/tesla_powerwall.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/sunsynk.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/solis_cloud.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/solax_sx4.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/solax_cloud.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/solaredge.yaml | Updates days_previous commentary; removes additional example days/weights. |
| templates/solar_assistant_growatt_sph.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/solar_assistant_growatt_spa.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/sofar.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/sofar_modbus.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/sigenergy_sigenstor.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/luxpower.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/kostal.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/huawei.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/givenergy_givtcp.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/givenergy_ems.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/givenergy_cloud.yaml | Updates days_previous commentary and changes example days_previous from 1 to 7; removes weight example. |
| templates/ginlong_solis.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/ge_cloud_octopus_standalone.yaml | Updates days_previous commentary; simplifies example days_previous list to just 7 and removes weight example. |
| templates/fronius.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/fox.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
| templates/fox_cloud.yaml | Updates days_previous commentary and removes days_previous_weight example block. |
Comment on lines
266
to
271
| "holiday_days_left": 0, | ||
| "load_forecast_only": False, | ||
| "days_previous": [7, 14], | ||
| "days_previous_weight": [1.0, 0.5], | ||
| "days_previous_auto": False, | ||
| "metric_min_improvement": 0.1, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.