Repository navigation
fix(quote): build and pull from Splunk GHCR - #323
Merged
Merged
Conversation
Enable quote in the prod-release matrix and point the k8s manifest at ghcr.io/splunk/opentelemetry-demo/otel-quote so update-and-release can rewrite the image tag. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
quotein the prod-release build matrix (build: true,replace_registry: true).src/quote/quote-k8s.yamlatghcr.io/splunk/opentelemetry-demo/otel-quote:2.0.8so update-and-release can rewrite the tag.build: falseand pullingghcr.io/open-telemetry/demo:2.2.0-quote, which caused run 39937505904 to skip the image build and fail the manifest updater.Test plan
services=quoteotel-quoteis built and pushed to GHCRquote-k8s.yamlwithout "No image line found"Made with Cursor