Repository navigation
docs(api): document HTTP SQL response formats and v1+json key order - #2447
Merged
Merged
Conversation
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://ccea18f5.spiceai-org-website.pages.dev |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The documentation depends on the still-open spiceai/spiceai#15676, whose merge and inclusion in v2.5 must be confirmed before publishing the described behavior.
No open issues 🎉
What changed in this PR
Documents HTTP SQL response formats in the hand-written API overview, including the v2.5 behavior introduced by spiceai/spiceai#15676. This documentation should merge after that runtime change.
Changes:
- Lists supported response formats for
/v1/sqland/v1/nsql. - Explains v1+json streaming, key order, and decimal precision changes, with a JSON example and client compatibility guidance.
| File | Description |
|---|---|
website/docs/api/overview.md |
Adds HTTP SQL response format documentation and v2.5 compatibility notes. |
Review effort: Balanced
krinart
approved these changes
Oct 28, 2026
Contributor
|
🚀 deployed to https://de6d42e5.spiceai-org-website.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an HTTP SQL Response Formats section to the API overview (
website/docs/api/overview.md). It flags theapplication/vnd.spiceai.sql.v1+jsonchanges in spiceai/spiceai#15676:schema,data,row_count,sql. Before,row_countcame first. It moved afterdatabecause the response now streams, and the count is only known after the last row.application/jsonandtext/csv. Before, it buffered the whole result.DECIMALvalues keep their exact digits and scale, the same asapplication/json. Before, they were converted to f64.JSON object keys are unordered, so the SDKs and any client that parses the body as an object are unaffected. The note tells clients that read the body as text or rely on key positions to parse it as JSON instead.
Why here
The
/v1/sqland/v1/nsqlAPI pages (website/docs/api/HTTP/post-*.api.mdx) are generated fromwebsite/public/openapi.json, whichupdated_openapi.ymlsyncs from the runtime. A hand edit there would be overwritten on the next sync. The overview page is hand-written and already holds the cross-cutting HTTP notes, such as Request Correlation.Merge order
Checks
npx prettier --check website/docs/api/overview.mdpasses with the repo.prettierrc.