Repository navigation
docs: request-context metric labels, HTTPS redirect guard, ORC metadata limit, scalar function memory, OTLP log record size - #2440
Merged
Conversation
…ta limit, scalar output reservations, OTLP log record size
Contributor
✅ Pull with Spice PassedPassing checks:
|
3 tasks done
Contributor
There was a problem hiding this comment.
🟢 Approved
The documentation updates have no blocking issues; the remaining lower-bound reservation wording clarification is minor.
1 open issue
What changed in this PR
This PR updates vNext documentation for five runtime changes covering metric labels, HTTPS redirect protection, and resource limits. Versioned documentation remains unchanged because these changes postdate v2.4.0.
Changes:
- Refresh request-context metric labels and Datadog tag examples.
- Document HTTPS redirect restrictions and their scope.
- Describe ORC metadata, scalar-function memory, and OTLP log record limits.
| File | Description |
|---|---|
website/docs/reference/memory.md |
Describes scalar-function output reservations. |
website/docs/reference/file_format.md |
Documents ORC metadata decompression limits. |
website/docs/monitoring/datadog/index.md |
Updates metric tag examples. |
website/docs/features/observability/index.md |
Defines current request-context labels. |
website/docs/features/data-ingestion/index.md |
Documents OTLP string-data limits and rejection behavior. |
website/docs/components/data-connectors/https/index.md |
Clarifies redirect protection and exclusions. |
Review effort: Balanced
Contributor
|
🚀 deployed to https://94f530b5.spiceai-org-website.pages.dev |
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
October 27, 2026 14:54
3 tasks done
3 tasks done
Contributor
|
🚀 deployed to https://f6bf00e3.spiceai-org-website.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR documents five changes merged to
spiceai/spiceaitrunk. All five are vNext only (website/docs/): none of the merge commits is an ancestor ofv2.4.0, so theversion-2.4.xsnapshot correctly documents the earlier behavior.features/observability,monitoring/datadog): the (request context) labels are nowprotocol,cache_namespace_kind,client,runtime,runtime_version, andruntime_system.clientis a known Spice client name orother. Theclient_version,client_system, anduser_agentlabels are gone, so the Datadog cardinality note and its blocklist example no longer name them.components/data-connectors/https): a JSON API dataset refuses a redirect to a host name that resolves to a private, loopback, or link-local address, and the error is documented. The sentence "Cross-origin redirects are rejected." is removed: the redirect policy follows a cross-origin redirect to a public host (Unverified, code inspection only; see Verification).reference/file_format).reference/memory).features/data-ingestion).Source PRs
Verification
Every value below was read on
spiceai/spiceaiorigin/trunkat814e639e8eb55eacbe3f3fadaad2ec0aaf712c05. These are name, default, and error-string claims. The behavior statements come from reading the code, Unverified, code inspection only, except where a source PR records its own run.The source PRs ran their own reproductions. spiceai/spiceai#15594 ran a
spiceddebug build against a local 302 tolocalhost4and recordedRefused to connect to localhost4: the HTTPS data connector does not follow a redirect …in its body. The runtime was not run for this docs PR.Later revert, removal, or retune:
gh pr list --repo spiceai/spiceai --state merged --search "<symbol>"forKNOWN_CLIENTS,redirect_destination_guard,MAX_LOGS_BATCH_STRING_BYTES, andoutput_reservationreturned only the source PRs above.Known limitations: spiceai/spiceai#15594 says the dataset's own host and a proxy are not checked at redirect time, and the page states this. The versioned
https/index.mdcopies (2.0.x–2.4.x) still say "Cross-origin redirects are rejected."v2.4.0'shttps.rs:979redirect policy has no same-origin check either, but that is code inspection only. This PR leaves the versioned copies for an audit pass that can run the connector.Propagation (vNext only, since none of the merge commits is in
v2.4.0):Build:
NODE_OPTIONS=--max-old-space-size=12288 npm run build(inwebsite/) passed:Style grep (
docs-pr-hygiene.md§"Local Docusaurus build gate") over the added lines: no hits.Test plan
cd website && npm run buildpasses (output above)Review gate
codexnot installed (receipt:attempt=codex result=not-installed,engine=none)/security-review: no findings (docs-only Markdown diff)/simplify: not run — docs-only diff, no code