Repository navigation
docs: show partition_by as a list in the datasets reference example - #2439
Merged
Merged
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
There was a problem hiding this comment.
🟢 Approved
All six edits consistently correct the YAML value type, with no unresolved issues.
No open issues 🎉
What changed in this PR
This PR corrects the datasets reference example to use the list format expected by acceleration.partition_by, preventing the documented scalar-type parsing error.
Changes:
- Replaces
partition_by: block_datewithpartition_by: [block_date]. - Applies the correction to current documentation and versions 2.0.x–2.4.x without changing surrounding configuration.
| File | Description |
|---|---|
| website/versioned_docs/version-2.4.x/reference/spicepod/datasets.md | Corrects the 2.4.x partitioning example. |
| website/versioned_docs/version-2.3.x/reference/spicepod/datasets.md | Corrects the 2.3.x partitioning example. |
| website/versioned_docs/version-2.2.x/reference/spicepod/datasets.md | Corrects the 2.2.x partitioning example. |
| website/versioned_docs/version-2.1.x/reference/spicepod/datasets.md | Corrects the 2.1.x partitioning example. |
| website/versioned_docs/version-2.0.x/reference/spicepod/datasets.md | Corrects the 2.0.x partitioning example. |
| website/docs/reference/spicepod/datasets.md | Corrects the current partitioning example. |
Review effort: Balanced
Contributor
|
🚀 deployed to https://80ff5dc4.spiceai-org-website.pages.dev |
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
October 27, 2026 16:57
Contributor
|
🚀 deployed to https://fae4c4dd.spiceai-org-website.pages.dev |
Copilot
AI
dismissed their stale review, a newer Copilot review was requested
October 27, 2026 19:04
Contributor
|
🚀 deployed to https://31b58b01.spiceai-org-website.pages.dev |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
acceleration.partition_byexample in the datasets reference shows a scalar,partition_by: block_date. Spice has always parsedpartition_byas a list (Vec<PartitionedBy>from v2.0.0 through trunk), so copying the example breaks bothspice validateandspicedstartup:This PR changes the example to
partition_by: [block_date]in the current docs and in the 2.0.x–2.4.x versioned copies. The Partitioning page already uses the list form.Evidence
All runs use
spice/spicedv2.4.0-rc.3.partition_by: block_date) failsspice validatewith the error above, andspicedexits with the same error.mode: filedataset withpartition_by: [region]validates andspicedstarts. Withpartition_by: regionit does not.Adversarial review (Codex,
adversarial-review --base origin/trunk)04b41ecf: approve, no material findings. Codex did not check older versions itself;partition_byisVec<PartitionedBy>in spiceai/spiceai at v2.0.0, v2.1.0, v2.2.0, v2.3.0 and trunk, so the list form is correct for every versioned copy.