Repository navigation
docs(cayenne): refresh_append_overlap is supported in v2.3.0 - #2202
Merged
Merged
Conversation
The version-2.3.x snapshot was cut on 2026-09-10, hours before #2191 retired the Cayenne refresh_append_overlap limitation, so the spicepod datasets and views references in it still tell readers the value fails to load under Cayenne. spiceai/spiceai removed the rejection in v2.2.1 and v2.3.0 honours the window like every other engine.
Contributor
✅ Pull with Spice PassedPassing checks:
|
Contributor
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
Contributor
|
🚀 deployed to https://95ff7851.spiceai-org-website.pages.dev |
lukekim
approved these changes
Sep 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
version-2.3.xsnapshot was published on 2026-09-10 at 11:24 UTC. #2191 — which retired the Cayennerefresh_append_overlaplimitation — merged on 2026-09-11 and sweptwebsite/docs/andversion-2.2.xonly. The freshly-cut snapshot therefore still carries the pre-correction text, so the v2.3.0 docs tell readers a supported knob fails to load. This is the "a freshly-cut snapshot arrives already-stale" case in the docs PR hygiene reference.A false negative capability claim is the costly kind: it reads as a limitation, so nothing flags it and the reader's remedy is to stop using a feature that works.
website/versioned_docs/version-2.3.x/components/data-accelerators/cayenne/index.mdalready lacks the limitation bullet (#2186 removed it in vNext before the cut), so within the snapshot the accelerator page and these two reference pages contradict each other today.Scope: only
version-2.3.x. The 1.9.x–2.1.x snapshots correctly keep the limitation (the rejection is in their source), andversion-2.2.xcorrectly carries the per-patch wording ("from v2.2.1").Source PRs
git tag --contains→ v2.2.1, v2.3.0)Test plan
cd website && npm run build:grep -rln "Not supported by the Spice Cayenne" website/versioned_docs/version-2.3.x/ | wc -lvsgit diff --cached --name-only -- website/ | wc -l:grep -rn "file-mode Cayenne\|does not yet support refresh_append_overlap\|Not supported by the Spice Cayenne" website/leaves the claim standing only where it is true: 1.9.x, 1.10.x, 1.11.x, 2.0.x, 2.1.x, plus the "from v2.2.1" wording in 2.2.x.versioned_docs/version-2.3.x/reference/spicepod/datasets.mdand.../views.md, matching the diff.Reproduction
Doc said (
website/versioned_docs/version-2.3.x/reference/spicepod/datasets.md:765at docsc0f47f88; identical sentence atviews.md:196):Code says — the rejection is present at v2.2.0 and absent at v2.3.0:
and v2.3.0 applies the window with no engine test —
crates/runtime/src/datafusion/mod.rs:3126(v2.3.0):Behavior claim: not run — establishing the absence of a load-time rejection needs a
spicedbuild at the v2.3.0 tag plus an object store for a file-mode Cayenne dataset. The corrected claim is an existence claim about a rejection arm, settled by the two greps above, so this correction is Reproduced on that basis.