Repository navigation
build: pin datafusion-federation at spiceai/datafusion-federation#94 - #92
Merged
Merged
Conversation
#94 pushes a limit into the federated scan (refs spiceai/spiceai#13770). Spice pins both forks, so they must name the same datafusion-federation revision.
There was a problem hiding this comment.
🟢 Approved
The manifest and lockfile consistently reference the intended revision, with no blocking issues identified.
0 open findings
What changed in this PR
Updates the federation dependency to include upstream limit pushdown support and align with Spice’s required revision.
Changes:
- Pins
datafusion-federationto109661c. - Synchronizes the lockfile with the manifest.
| File | Description |
|---|---|
| Cargo.toml | Updates the dependency revision. |
| Cargo.lock | Records the matching Git revision. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
krinart
added a commit
to spiceai/spiceai
that referenced
this pull request
Oct 15, 2026
…ks, not a Spice rule A LIMIT, or the fetch of an ORDER BY ... LIMIT, above a projection a source refuses now reaches the federated scan beneath it through the physical plan, so the remote SQL carries it with no derived table: - spiceai/datafusion#260 (cf084aa): PushdownSort carries an eliminated sort's fetch through the single-input round-robin repartition the planner puts above a single-partition scan. The pin also brings #259, which keeps placeholder type inference linear in the depth of an expression. - spiceai/datafusion-federation#94 (109661c): VirtualExecutionPlan takes the limit into its SQL, and SchemaCastScanExec passes it through. - spiceai/datafusion-table-providers#92 (54d9010): moves its datafusion-federation pin with it. This replaces PushLimitBelowProjection, which rewrote the logical plan to move the limit below the projection and read the limited rows back as a derived table. The guards are in federation::tests::scan_pushdown, and the fork ledger records each patch and its guard.
6 tasks done
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
datafusion-federationat109661c, thespiceai-55merge of spiceai/datafusion-federation#94, which pushes a limit into the federated scan (refs spiceai/spiceai#13770). Spice pins both forks, so they must name the samedatafusion-federationrevision.Verification
Run at 400de52 on 2026-10-15: