lnpeer: drop support for legacy closing fee negotiation - #10861
Merged
Conversation
ecdsa
force-pushed
the
fix_unbounded_closing_fee
branch
3 times, most recently
from
August 17, 2026 15:21
1b22b3f to
c082a70
Compare
ecdsa
marked this pull request as ready for review
August 17, 2026 16:16
SomberNight
reviewed
Aug 17, 2026
Also, do not use the latest ctx fee as maximum. Instead, define the maximum as twice our_fee capped with FEERATE_MAX_DYNAMIC
ecdsa
force-pushed
the
fix_unbounded_closing_fee
branch
from
August 18, 2026 08:53
85a19a0 to
ca4f01e
Compare
ecdsa
changed the title
SomberNight
force-pushed
the
fix_unbounded_closing_fee
branch
from
August 18, 2026 16:19
659dad5 to
01fb37b
Compare
ecdsa
commented
Aug 19, 2026
- previously the code being unit-tested behaved different than in production: the submissive branch was guarded with "if not is_initiator and not self.config.TEST_SHUTDOWN_FEE_RANGE", so it never entered during unit tests - unit tests to test both direction: either Alice or Bob can send shutdown first - ensure min_fee always meets relay_fee
SomberNight
force-pushed
the
fix_unbounded_closing_fee
branch
from
August 19, 2026 12:51
01fb37b to
75bd374
Compare
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that BOLT2 used to bound fee_satoshis by the base fee of the final ctx, but that requirement was removed in lightning/bolts#847.
Also fix the "strictly between" check, which was skipped when their previously proposed fee was 0.