swap_server: fix some issues running swap server - #10850
Open
accumulator wants to merge 1 commit into
Open
Conversation
accumulator
force-pushed
the
swapserver_fixes
branch
5 times, most recently
from
August 14, 2026 10:52
3b1dd34 to
92d5d7a
Compare
- SwapServerPlugin.server was never set, so the guard on 'use the first wallet loaded' was ineffective - exclude non-lightning wallets for consideration - disabling the plugin left the server running - use async with .. in run_nostr_server(). non-async would block on __exit__, fut.result(timeout=5) would time-out since it runs on the asyncio thread.
accumulator
force-pushed
the
swapserver_fixes
branch
from
August 14, 2026 11:15
92d5d7a to
5d0a00e
Compare
accumulator
marked this pull request as ready for review
August 14, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwapServerPlugin.serverwas never set, so the guard on 'use the first wallet loaded' was ineffectiveasync with.. inrun_nostr_server(). non-async would block on__exit__,fut.result(timeout=5)would time-out since it runs on theasynciothread.