[test]: Tests for Borrow

[rijulpoudel]

Fixes #8524

Summary by CodeRabbit

• Tests
  • Added coverage for Borrow workflows, including invoice details, dates, agents, shipments, and associated fields.
  • Added validation for linking existing and newly created agents to a Borrow.
  • Added checks that shipment information is saved and retrieved correctly.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 710ed065-afe8-4c48-8727-869d1a3c21c0

📥 Commits

Reviewing files that changed from the base of the PR and between ed88422 and f800edf.

📒 Files selected for processing (1)

• specifyweb/backend/businessrules/tests/test_borrow.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

The pull request adds tests for Borrow business rules. The tests cover invoice data, existing and new borrower agents, and Shipment fields.

Changes

Borrow workflow tests

Layer / File(s)	Summary
Borrow persistence validation specifyweb/backend/businessrules/tests/test_borrow.py	Adds four tests for Borrow invoice fields, existing and new Borrower agents, and full-field Shipment persistence.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to f800e

The added Borrow workflow tests cover the stated persistence scenarios without an identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Testing Instructions	⚠️ Warning	The pull request description contains no testing instructions; it only says “Fixes #8524.” The added test module clearly identifies four Borrow scenarios and covers Borrow, Borrowagent, Agent, and Shi…	Add a testing section with the exact command, for example ./ve/bin/python manage.py test specifyweb.backend.businessrules.tests.test_borrow. State that the test covers Borrow invoice details, existing and new agents, and shipment field pe…

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies that the pull request adds tests for Borrow functionality, which matches the main changeset and objectives.
Linked Issues check	✅ Passed	The pull request satisfies #8524. It adds BorrowTests with coverage for invoice number and date persistence, an existing agent, a new agent, and shipment fields. Each test reloads persisted records …
Out of Scope Changes check	✅ Passed	The pull request adds only specifyweb/backend/businessrules/tests/test_borrow.py. The tests directly support the Borrow test objective in #8524. No unrelated production or feature changes are presen…
Automatic Tests	✅ Passed	The PR adds specifyweb/backend/businessrules/tests/test_borrow.py. The file contains four discoverable test_ methods in BorrowTests, which inherits from ApiTests and therefore Django `TestCase…

Full details: Testing Instructions

Explanation

The pull request description contains no testing instructions; it only says “Fixes #8524.” The added test module clearly identifies four Borrow scenarios and covers Borrow, Borrowagent, Agent, and Shipment relationships, but it does not tell reviewers how to run the tests or define the validation scope.

Resolution

Add a testing section with the exact command, for example ./ve/bin/python manage.py test specifyweb.backend.businessrules.tests.test_borrow. State that the test covers Borrow invoice details, existing and new agents, and shipment field persistence, and report the result.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-8524

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}