Skip to content

chore: bump baseline-browser-mapping version - #8525

Open
g1rly-c0d3r wants to merge 1 commit into
mainfrom
issue-8523
Open

g1rly-c0d3r wants to merge 1 commit into
mainfrom
issue-8523

Conversation

@g1rly-c0d3r

@g1rly-c0d3r g1rly-c0d3r commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #8523

Addresses https://github.com/specify/specify7/security/dependabot/326

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • light general testing

Summary by CodeRabbit

  • Chores
    • Updated frontend browser compatibility configuration to use the specified baseline browser mapping version.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e689cc0d-4c72-4473-b5d1-34256f45a51d

📥 Commits

Reviewing files that changed from the base of the PR and between ed88422 and a77eddf.

⛔ Files ignored due to path filters (1)
  • specifyweb/frontend/js_src/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • specifyweb/frontend/js_src/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The frontend package configuration adds an override for baseline-browser-mapping at version ^2.11.0.

Changes

Frontend dependency configuration

Layer / File(s) Summary
Add browser mapping override
specifyweb/frontend/js_src/package.json
The package configuration adds an overrides entry for baseline-browser-mapping with version ^2.11.0.

Suggested reviewers: carolinedenis

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: ⚪ Minimal · up to a77ed

The dependency update is consistent with the lockfile and does not introduce an evidenced merge-blocking risk.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Testing Instructions ⚠️ Warning The testing instructions are not clear or component-specific. The PR changes the frontend dependency override and updates specifyweb/frontend/js_src/package-lock.json from baseline-browser-mapping Replace “light general testing” with explicit frontend steps. For example: from the repository root, run make frontend; then run npm run typecheck and npm run unitTests from specifyweb/frontend/js_src. State that dependency installa…
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the baseline-browser-mapping dependency version.
Linked Issues check ✅ Passed Issue #8523 requires a baseline-browser-mapping version bump. The pull request adds the ^2.11.0 override in specifyweb/frontend/js_src/package.json. The available issue and PR evidence shows no …
Out of Scope Changes check ✅ Passed The reviewed change contains one dependency configuration update in specifyweb/frontend/js_src/package.json. This change directly supports issue #8523. No unrelated source or test changes are report…
Automatic Tests ✅ Passed PASS: The PR changes only the baseline-browser-mapping dependency override and its lockfile entry. It does not change application logic or testable behavior, so new automatic tests are not necessary…
Full details: Testing Instructions

Explanation

The testing instructions are not clear or component-specific. The PR changes the frontend dependency override and updates specifyweb/frontend/js_src/package-lock.json from baseline-browser-mapping 2.10.19 to 2.11.23. The only instruction is “light general testing,” with no frontend directory, install command, build check, or expected result. The repository provides frontend checks such as make frontend and the frontend typecheck/unit-test commands.

Resolution

Replace “light general testing” with explicit frontend steps. For example: from the repository root, run make frontend; then run npm run typecheck and npm run unitTests from specifyweb/frontend/js_src. State that dependency installation and the frontend build must complete successfully.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8523

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@g1rly-c0d3r

Copy link
Copy Markdown
Contributor Author

@coderabbitai fullreview

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

@g1rly-c0d3r I will perform a complete new review of #8525.

✅ Action performed

Full review finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Bump baseline-browser-mapping version

1 participant