Skip to content

feat(keyboard-shortcuts): add customizable keyboard shortcuts - #8521

Draft
grantfitzsimmons wants to merge 30 commits into
mainfrom
issue-1746
Draft

grantfitzsimmons wants to merge 30 commits into
mainfrom
issue-1746

Conversation

@grantfitzsimmons

Copy link
Copy Markdown
Member

Begins to fix #1746

Rebased #5097 onto main, resolved the resulting conflicts. The keyboard-shortcut preferences now expose user tools directly (rather than as cryptic URLs), plus their icons, while URL-based shortcuts remain available as an advanced option (not sure how useful it will be in practice).

Dialog actions can also be configured, including shortcuts for closing and saving when those actions are available. I want to review what makes sense to prevent accidental misfires. Perhaps we combine the c or s keys with Alt/Command?

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add automated tests
  • Add relevant issue to release milestone

Testing instructions

  • Added Keyboard Shortcuts item to User tools - verify it looks good
  • For each shortcut on the Keyboard Shortcuts page that has a default value assigned, make sure that the default keyboard shortcuts we have set do not already have an action assigned to them (we don't want to overwrite default browser or OS actions, unless we really have to, or unless user would expect us to do so)
    • i.e open any non-specify webpage (google.com) and see if this key does anything (this needs to be verified in non-specify pages because if specify collides with a system shortcut, specify will take priority, and so you may not even know that it collides)
    • Verify this on Windows in Chrome and Firefox
    • Verify this on macOS in Chrome and Safari
    • (if possible) Verify this on Linux in Firefox
  • Check if any other common action is missing a keyboard shortcut that you believe we should add
  • Verify the ability to set a keyboard shortcut to any page (see feat(KeyboardShortcuts): add customizable shortcuts for common actions #5097 (comment))

maxpatiiuk and others added 30 commits July 26, 2025 08:07
"Keyboard" is a bit too generic/ambiguous
- Replace "show nodes with children only" checkbox with a toggle button.
  Reasons:
  - The checkbox was the only thing below the tree viewer - occupying
    an entire line of horizontal space.
  - Because of how Tab and Shift+Tab keys are used in the tree viewer,
    moving focus to elements below the tree viewer is not possible - you
    can only move above the tree viewer. That made this checkbox
    inaccessible from keyboard
  - The label for this checkbox is long, adding visual noise - it's
    cleaner as a small tidy button
- Don't display split view controls if split view is not enabled to
  reduce visual clutter
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Add keyboard shortcuts for common actions

2 participants