feat(keyboard-shortcuts): add customizable keyboard shortcuts - #8521
Draft
grantfitzsimmons wants to merge 30 commits into
Draft
grantfitzsimmons wants to merge 30 commits into
grantfitzsimmons wants to merge 30 commits into
Conversation
"Keyboard" is a bit too generic/ambiguous
- Replace "show nodes with children only" checkbox with a toggle button.
Reasons:
- The checkbox was the only thing below the tree viewer - occupying
an entire line of horizontal space.
- Because of how Tab and Shift+Tab keys are used in the tree viewer,
moving focus to elements below the tree viewer is not possible - you
can only move above the tree viewer. That made this checkbox
inaccessible from keyboard
- The label for this checkbox is long, adding visual noise - it's
cleaner as a small tidy button
- Don't display split view controls if split view is not enabled to
reduce visual clutter
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begins to fix #1746
Rebased #5097 onto
main, resolved the resulting conflicts. The keyboard-shortcut preferences now expose user tools directly (rather than as cryptic URLs), plus their icons, while URL-based shortcuts remain available as an advanced option (not sure how useful it will be in practice).Dialog actions can also be configured, including shortcuts for closing and saving when those actions are available. I want to review what makes sense to prevent accidental misfires. Perhaps we combine the
corskeys with Alt/Command?