Repository navigation
test: fix undo-restore flow test stranded on ManageShelvesScreen - #57
Merged
Merged
Conversation
The nightly instrumented run has failed on undo_restores_a_shelf_deleted_with_the_keep_products_strategy since the Storage rework moved shelf editing (and the undo snackbar) off the tabbed LocationDetailScreen onto ManageShelvesScreen: after Undo the test tapped 'Top shelf' on the manage screen, where products are never rendered, and timed out waiting for 'Milk'. Navigate back to the location detail after the restore, as a user would, and assert the product there. Verified on-device: all 4 tests in the class pass. Claude-Session: https://claude.ai/code/session_01DgpTaTHThASmowZxsvHPfn
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the nightly Instrumented tests workflow, red on every run since the Storage rework (v0.1.22 era).
Cause:
DeleteShelfStrategyFlowTest.undo_restores_a_shelf_deleted_with_the_keep_products_strategy_along_with_its_productsstill assumed the pre-rework layout where delete/undo happened on the tabbed LocationDetailScreen. Editing moved to ManageShelvesScreen, so after Undo the test tapped "Top shelf" on the manage screen — where products are never rendered — and timed out waiting for "Milk". The app behavior itself is correct (verified in logcat: restore POST + both refetches succeed).Fix: after the restore, navigate back to the location detail as a user would and assert the shelf tab + product there.
Verified: all 4 tests in the class pass on a real device (Pixel 7 Pro); ktlint + detekt clean.