Repository navigation
Ask the bug form for the device context that decides visual bugs - #39
Merged
Merged
Conversation
The free-text "Phone and Android version" field left the two things that actually explain a visual difference unasked: whether Android's "Bold text" is on, and what the font/display size sliders are set to. Both change how every app renders, so two phones on the same build legitimately look different — which is all of #32, after it was chased into the type system first. Phone becomes a dropdown of the phones in the test group (Pixel 7 Pro, Pixel 10, Galaxy S24, other), and the form now asks for Bold text, font and display size, and — when a report compares two phones — which screenshot came from which, with those settings for both. Bold text is required, with a "not sure" option so it can't become a wall. The rest stay optional; a tester who has never touched them can write "default" and move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32. No issue to link — this is a process fix.
Why
#32 ("looks different on Pixel and Samsung") turned out not to be a code bug at all: one of the tester's phones has Android's Bold text accessibility setting on and the other doesn't, so the same build renders at different weights. I found that out only after measuring the type on-device, misreading the result, and getting most of the way through replacing the app's variable font with five static files. The control run showed the original font was fine.
The device context that settles this kind of report was never asked for. The form had a free-text "Phone and Android version" box and nothing else — so the two settings that actually decide a visual difference went unreported, and the report was ambiguous about which screenshot came from which phone.
Asking a tester to remember three settings every time is fragile. The form can just ask.
What changes
The screenshot, steps, expected-result and build-version fields are untouched.
Validated as GitHub issue-form YAML (parses; all dropdowns and required flags as intended).