Add Guzzle 8 compatibility - #119
Merged
Merged
Conversation
Widen the guzzlehttp/guzzle constraint to allow ^8.0 and add a Guzzle
axis to the test matrix so both 7.x and 8.x are covered.
The package's Guzzle surface is limited to constructing a Client and
calling request('GET', $url, ['query' => ...]) plus getStatusCode() and
getBody() on the response, none of which changed in Guzzle 8, so no
source changes are needed.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
laravel/framework 11.x and 12.x require guzzlehttp/guzzle ^7.8.2, so the Guzzle 8 jobs for those Laravel versions could never resolve. Laravel 13 is the first release allowing ^7.8.2 || ^8.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
actions/checkout@v4 and actions/cache@v4 run on Node.js 20, which is deprecated and force-run on Node.js 24 by the runners. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
|
Thanks @marijoo! Nicely researched, and I appreciate you working out the Laravel 11/12 exclusions instead of just widening the constraint and hoping. |
Contributor
Author
|
Thanks @freekmurze, was a pleasure. Thank you for all your packages and good work. Greetings from Germany. 🤙🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the guzzlehttp/guzzle constraint to allow ^8.0 and add a Guzzle axis to the test matrix so both 7.x and 8.x are covered.
The package's Guzzle surface is limited to constructing a Client and calling request('GET', $url, ['query' => ...]) plus getStatusCode() and getBody() on the response, none of which changed in Guzzle 8, so no source changes are needed.