Repository navigation
Sort silent payment codes sharing a scan key before assigning k - #50
Closed
macgyver13 wants to merge 1 commit into
Closed
macgyver13 wants to merge 1 commit into
macgyver13 wants to merge 1 commit into
Conversation
… scan key before assigning k
Collaborator
|
Thanks for this - I've made the change separately in 59f43e3, using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a transaction has two or more silent payment outputs sharing a scan key, Sparrow and SeedSigner assigned k in different orders and derived different output addresses.
@notTanveer discovered this issue when testing Sparrow and SeedSigner - Thank you for sharing!
BIP375 Text:
Test
testBip375ThreeOutputsSameScanKeyclones "can finalize: three sp outputs (same scan key) - output 0 uses label=1, outputs 1 and 2 uses label=2 (same spend key)" from BIP375 v1.1.1 test vectors proposed in BIPs PR 2207. Note that v1.1.1 is still proposed, waiting for BIP authors to confirm spec interpretation is accurate.Happy to address any requested changes or close this PR in favor of your solution.