Add LIS3DSH Support - #12
Open
lpritch wants to merge 9 commits into
Open
Conversation
… Added settings and a class for the 3dSh
…egister addresses and codes during communication. Used device defaults for all other registers.
…is assumed by the rest of the library. Moved setting that bit outside of applySettings() so users can change it and still use that function. Also made applySettings() preserve settings that it does not touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for the LIS3DSH. It is easy to confuse LIS3DH and LIS3DSH boards when buying, so this change makes it easy to use either board through the same library API.
I have only changed the original code in one place, when LIS3DHCore checks the WHOAMI register. That code now returns success if the code returned is either the LIS3DH code or the LIS3DSH code. The new LIS3DSH subclass uses exactly the same settings and has exactly the same method signatures as the LIS3DH to make it easy to substitute one chip for the other.