Skip to content

fix(builder): persist custom listing card fields#2901

Open
syedgalib wants to merge 3 commits into
sovware:developmentfrom
syedgalib:fix/resource-card-fields-persist
Open

fix(builder): persist custom listing card fields#2901
syedgalib wants to merge 3 commits into
sovware:developmentfrom
syedgalib:fix/resource-card-fields-persist

Conversation

@syedgalib

@syedgalib syedgalib commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

Preserve stable custom-field widget keys while building listing resource card widget options. Saved card widgets are resolved through generated keys, original widget keys, and widget names so selected custom fields survive remount and save cycles.

How to reproduce the issue or how to test the changes

  1. Add dynamic custom fields to the grid and list card layouts, both with and without thumbnails.
  2. Save the directory builder, then reload or remount it.
  3. Confirm the custom fields remain selected and both custom and built-in widgets continue to save correctly.

Any linked issues

N/A

Checklist

@Armanul46 Armanul46 added this to the v8.8.8 milestone Jul 20, 2026

@RabbiIslamRony RabbiIslamRony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syedgalib, please remove the build and POT files. Also, resolve any merge conflicts.

@RabbiIslamRony

Copy link
Copy Markdown
Member

@syedgalib I couldn't reproduce this locally.

@RabbiIslamRony

Copy link
Copy Markdown
Member

@syedgalib The issue is reproducible locally, and the fix works correctly. However, a new issue appears with previously saved fields: they disappear after the first reload/save. If those fields are added again and saved, they persist correctly after reload. So, a migration is needed to normalize the previously saved field data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants