Upgrade Core to `4707860933842426b0e9d1647215921967077c2a` by jviotti · Pull Request #893 · sourcemeta/one

jviotti · 2026-05-12T22:56:45Z

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

cubic-dev-ai

1 issue found across 38 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/metapack/metapack.cc">

<violation number="1" location="src/metapack/metapack.cc:55">
P2: Writing `extension.size()` with `put_dword` changes this field to little-endian, but readers still parse it as native-endian. This can break metapack parsing on big-endian targets.</violation>
</file>

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.}

cubic-dev-ai · 2026-05-12T23:06:24Z

+  writer.put_bytes(reinterpret_cast<const std::byte *>(mime.data()),
+                   mime.size());
+
+  writer.put_dword(static_cast<std::uint32_t>(extension.size()));


P2: Writing extension.size() with put_dword changes this field to little-endian, but readers still parse it as native-endian. This can break metapack parsing on big-endian targets.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/metapack/metapack.cc, line 55: <comment>Writing `extension.size()` with `put_dword` changes this field to little-endian, but readers still parse it as native-endian. This can break metapack parsing on big-endian targets.</comment> <file context> @@ -46,17 +46,17 @@ static auto write_binary_header(std::ostream &output, + writer.put_bytes(reinterpret_cast<const std::byte *>(mime.data()), + mime.size()); + + writer.put_dword(static_cast<std::uint32_t>(extension.size())); if (!extension.empty()) { // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) </file context>

Suggested change

writer.put_dword(static_cast<std::uint32_t>(extension.size()));

const auto extension_size{static_cast<std::uint32_t>(extension.size())};

// NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)

writer.put_bytes(reinterpret_cast<const std::byte *>(&extension_size),

sizeof(extension_size));

augmentcode · 2026-05-12T23:08:05Z

🤖 Augment PR Summary

Summary: This PR upgrades the pinned sourcemeta/core (and related blaze/jsonbinpack) dependencies and adapts this repo (and vendored deps) to the new Core I/O layer.

Changes:

Switches multiple writers to sourcemeta::core::atomic_write_file (BuildState persistence, index generators, metapack output) and introduces BinaryWriter/BinaryReader usage for binary serialization.
Adds/links the new Core io component across CMake targets and vendored dependencies.
Improves configuration file read error mapping by catching Core I/O exceptions and rethrowing ConfigurationReadError.
Updates the CLI path handling to use Core canonical/weakly_canonical and reports typed I/O errors in main.
Extends URITemplateRouter to register stable operation_ids, validates uniqueness/format, and updates route generation accordingly.
Bumps URITemplateRouterView serialization format (v6) and adds operation-id lookup in the view.
Refactors jsonbinpack runtime streams to build on Core binary I/O primitives and inlines varint encode/decode.

Technical Notes: The new Core I/O module introduces atomic file writing, stream/file-to-string helpers, and a richer set of typed I/O errors that replace some std::filesystem::filesystem_error flows.

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 3 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-05-12T23:08:06Z

-    }
+    sourcemeta::core::atomic_write_file(path, [&](std::ostream &stream) {
+      sourcemeta::core::BinaryWriter writer{stream};
+      writer.put_dword(STATE_MAGIC);


src/build/state.cc:1218: BuildState::save now writes header fields via BinaryWriter::put_dword (little-endian), but BuildState::load still reads them with raw memcpy into native uint32_t, so on big-endian systems the state file will be rejected/garbled. Other locations where this applies: src/metapack/metapack.cc:55.

Severity: medium

Other Locations

src/metapack/metapack.cc:55

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

github-actions

Benchmark Index (enterprise)

Details

Benchmark suite	Current: `ebafa92`	Previous: `709f4bd`	Ratio
`Add one schema (0 existing)`	`230` ms	`193` ms	`1.19`
`Add one schema (100 existing)`	`26` ms	`20` ms	`1.30`
`Add one schema (1000 existing)`	`88` ms	`60` ms	`1.47`
`Add one schema (10000 existing)`	`919` ms	`772` ms	`1.19`
`Update one schema (1 existing)`	`19` ms	`14` ms	`1.36`
`Update one schema (101 existing)`	`26` ms	`20` ms	`1.30`
`Update one schema (1001 existing)`	`86` ms	`62` ms	`1.39`
`Update one schema (10001 existing)`	`717` ms	`521` ms	`1.38`
`Cached rebuild (1 existing)`	`6` ms	`4` ms	`1.50`
`Cached rebuild (101 existing)`	`8` ms	`5` ms	`1.60`
`Cached rebuild (1001 existing)`	`32` ms	`18` ms	`1.78`
`Cached rebuild (10001 existing)`	`278` ms	`158` ms	`1.76`
`Index 100 schemas`	`136` ms	`105` ms	`1.30`
`Index 1000 schemas`	`1049` ms	`835` ms	`1.26`
`Index 10000 schemas`	`13502` ms	`11064` ms	`1.22`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark Index (community)

Details

Benchmark suite	Current: `ebafa92`	Previous: `709f4bd`	Ratio
`Add one schema (0 existing)`	`225` ms	`218` ms	`1.03`
`Add one schema (100 existing)`	`22` ms	`21` ms	`1.05`
`Add one schema (1000 existing)`	`75` ms	`73` ms	`1.03`
`Add one schema (10000 existing)`	`909` ms	`616` ms	`1.48`
`Update one schema (1 existing)`	`16` ms	`15` ms	`1.07`
`Update one schema (101 existing)`	`23` ms	`22` ms	`1.05`
`Update one schema (1001 existing)`	`75` ms	`73` ms	`1.03`
`Update one schema (10001 existing)`	`636` ms	`997` ms	`0.64`
`Cached rebuild (1 existing)`	`4` ms	`4` ms	`1`
`Cached rebuild (101 existing)`	`6` ms	`6` ms	`1`
`Cached rebuild (1001 existing)`	`26` ms	`25` ms	`1.04`
`Cached rebuild (10001 existing)`	`254` ms	`238` ms	`1.07`
`Index 100 schemas`	`135` ms	`105` ms	`1.29`
`Index 1000 schemas`	`1084` ms	`869` ms	`1.25`
`Index 10000 schemas`	`13320` ms	`12747` ms	`1.04`

This comment was automatically generated by workflow using github-action-benchmark.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/metapack/metapack.cc">

<violation number="1">
P2: Guard `create_directories(destination.parent_path())` with `has_parent_path()`; calling it with an empty parent path can throw on some standard library implementations.</violation>

<violation number="2">
P1: `assert(!output.fail())` is removed in release builds, so write/open failures can become silent; enable stream exceptions or explicit error checks for all writes.</violation>
</file>

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

cubic-dev-ai · 2026-05-13T02:46:31Z

@@ -8,7 +8,8 @@
 #include <cstring>     // std::memcpy


P1: assert(!output.fail()) is removed in release builds, so write/open failures can become silent; enable stream exceptions or explicit error checks for all writes.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/metapack/metapack.cc, line 74: <comment>`assert(!output.fail())` is removed in release builds, so write/open failures can become silent; enable stream exceptions or explicit error checks for all writes.</comment> <file context> @@ -53,44 +47,46 @@ static auto write_binary_header(sourcemeta::core::BinaryWriter &writer, - } - }); + std::ofstream output{destination, std::ios::binary}; + assert(!output.fail()); + + write_binary_header(output, mime, encoding, extension, duration, content, </file context>

Suggested change

#include <cstring> // std::memcpy

output.exceptions(std::ofstream::failbit | std::ofstream::badbit);

_{Tip: Review your code locally with the cubic CLI to iterate faster.}

cubic-dev-ai · 2026-05-13T02:46:31Z

@@ -8,7 +8,8 @@
 #include <cstring>     // std::memcpy


P2: Guard create_directories(destination.parent_path()) with has_parent_path(); calling it with an empty parent path can throw on some standard library implementations.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At src/metapack/metapack.cc, line 100: <comment>Guard `create_directories(destination.parent_path())` with `has_parent_path()`; calling it with an empty parent path can throw on some standard library implementations.</comment> <file context> @@ -101,6 +97,7 @@ auto metapack_write_json(const std::filesystem::path &destination, const std::chrono::milliseconds duration) -> void { std::ostringstream buffer; sourcemeta::core::stringify(document, buffer); + std::filesystem::create_directories(destination.parent_path()); write_metapack(destination, mime, encoding, extension, duration, buffer.str()); </file context>

jviotti marked this pull request as ready for review May 12, 2026 23:02

cubic-dev-ai Bot reviewed May 12, 2026

View reviewed changes

augmentcode Bot reviewed May 12, 2026

View reviewed changes

github-actions Bot reviewed May 12, 2026

View reviewed changes

Upgrade Core to 4707860933842426b0e9d1647215921967077c2a

5184641

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti force-pushed the core-io branch from 134aa3a to 5184641 Compare May 13, 2026 02:26

Fix performance

ebafa92

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

cubic-dev-ai Bot reviewed May 13, 2026

View reviewed changes

jviotti merged commit d0e008e into main May 13, 2026
5 checks passed

jviotti deleted the core-io branch May 13, 2026 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade Core to `4707860933842426b0e9d1647215921967077c2a`#893

Upgrade Core to `4707860933842426b0e9d1647215921967077c2a`#893
jviotti merged 2 commits into
mainfrom
core-io

jviotti commented May 12, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot May 12, 2026

Uh oh!

augmentcode Bot commented May 12, 2026

Uh oh!

augmentcode Bot left a comment

Uh oh!

Uh oh!

augmentcode Bot May 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

github-actions Bot left a comment •

edited

Loading

Uh oh!

github-actions Bot left a comment •

edited

Loading

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

cubic-dev-ai Bot May 13, 2026

Uh oh!

cubic-dev-ai Bot May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

-  writer.put_dword(static_cast<std::uint32_t>(extension.size()));
+  const auto extension_size{static_cast<std::uint32_t>(extension.size())};
+  // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast)
+  writer.put_bytes(reinterpret_cast<const std::byte *>(&extension_size),
+                   sizeof(extension_size));

	#include <cstring> // std::memcpy
	output.exceptions(std::ofstream::failbit \| std::ofstream::badbit);

Uh oh!

Conversation

jviotti commented May 12, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

augmentcode Bot commented May 12, 2026

Uh oh!

augmentcode Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

augmentcode Bot May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark Index (enterprise)

Uh oh!

github-actions Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Benchmark Index (community)

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

augmentcode Bot May 12, 2026 •

edited

Loading

github-actions Bot left a comment •

edited

Loading

github-actions Bot left a comment •

edited

Loading