Add optional YAML matrix loader for goldengen#138
Merged
Conversation
Add LoadMatrix, which reads a YAML matrix file and returns a runnable Config. Each fixture's CR comes from an inline spec or an external specFile (exactly one), unmarshalled into a fresh typed spec. specFile paths resolve relative to the matrix file. The result is validated via Config.Validate before returning. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sourcehawk
merged commit d376921
into
feature/version-matrix-goldens
2 of 3 checks passed
sourcehawk
added a commit
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #135
Adds
LoadMatrix, an optional YAML-driven entry point for the goldengen version matrix. It reads a matrix file that mirrorsConfigwithout its Go-only fields and returns aConfigready to run, withBuildandSchemesupplied as arguments.Behaviour
Config:dir,versions,exclude,fixtures.spec(inline CR) orspecFile(path relative to the matrix file). Both-set or neither-set is a load error.newSpec. The inlinespecis captured asjson.RawMessage(sigs.k8s.io/yaml has already converted YAML to JSON), which round-trips nested fields cleanly into the typed spec.requires/forbidscarrynameand optionalfor.Configis validated viaConfig.Validatebefore returning, so invariants such asfornot being a member ofversionsare enforced.Tests
Table-driven coverage for inline load, specFile load with relative resolution, both-set error, neither-set error,
for-not-in-versions error, missing file error, and that the producedConfigis runnable end to end (build a unit and render it).make allpasses.