Add goldengen: classify versions by firing-set and generate minimal goldens#137
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…133) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
sourcehawk
added a commit
that referenced
this pull request
Jun 1, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a new test-only package
pkg/testing/goldengenthat sweeps a consumer-supplied version universe, classifies versions into behaviorally-distinct gating regimes by firing-set, generates the minimal goldens covering them, and asserts per-fixture mutation gating.The package is opt-in: consumers that do not import it pay nothing, and no reconcile path references it.
Public API surface
Unitinterface (RegisteredMutations,FiringSet,RenderYAML) withResource(res, scheme)andComponent(comp, scheme)adapters that delegate rendering togolden.Serialize/golden.SerializeComponent.Config[T],Fixture[T],Expecttypes plusConfig.Validate()(non-empty Versions, non-nil Build, non-empty Dir, unique non-empty fixture names, non-empty expectation names, everyExpect.Fora member of Versions).Regime+ClassifyRegimes(versions, firing): groups versions by order-independent firing-set signature; representative is the first version in supplied order within a group.CheckGating(fixture, versions, firing): the Requires/Forbids lattice (existential vs. version-pinned).Manifest/FixtureManifest/RegimeManifest+Manifest.YAML().Generator[T],New(cfg),WithUpdate(bool), andRun(t): validates config, sweeps every fixture across every version, asserts gating, classifies into regimes, writes one golden per regime at<Dir>/<fixture>/<representative>.yamland a coverage manifest at<Dir>/manifest.yaml. HonorsWithUpdate.AssertCompleteand the YAML matrix loader are intentionally out of scope; they land in follow-up PRs.How verified
make allpasses (lint, fmt, full test suite, examples build).Towards #133