fix(skills): remove language-specific convention leakage#6
Merged
Conversation
The testing-a-feature and planning-a-feature skills illustrated
project-agnostic principles with Go-only conventions, which steer
agents wrong in non-Go repos:
- testing-a-feature prescribed Go's Test-prefix PascalCase test names,
the `-race` flag, and `nil`/`slice` vocabulary.
- planning-a-feature hardcoded `panic("unimplemented")`, "Go signatures,
TS types", and "unexported package" in its stub-realization examples.
Reword each to state the principle in stack-neutral terms so the skills
read the same in a Go repo, a Next.js app, or a Python service.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes language-specific (Go, TypeScript) examples and vocabulary from two skill files to comply with the project rule that skills must remain stack-agnostic. The edits only change illustrative wording; no behavior, control flow, or contract labels change.
Changes:
- Replaces Go-flavored terms (
nil,slice,-race) with neutral equivalents (absent,collection, "race/thread detector the toolchain provides") intesting-a-feature. - Replaces Go-style test name examples with quoted intent statements deferring to the project's naming convention.
- Rewrites contract realization examples in
planning-a-featureto droppanic("unimplemented"), Go signatures, TS types, and "unexported package" in favor of neutral phrasing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| skills/testing-a-feature/SKILL.md | Genericizes boundary/edge-case vocabulary, test-name examples, and race-detector guidance. |
| skills/planning-a-feature/SKILL.md | Rewords the two stub-realization bullets to remove Go/TS-specific examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two workflow skills illustrated stack-agnostic principles using Go-only conventions, which steer an agent wrong when the plugin runs in a non-Go repo. This rewords those illustrations to stack-neutral language so the skills read the same in a Go repo, a Next.js app, or a Python service — the test CLAUDE.md sets for every skill.
Changes
testing-a-feature: replace Go'sTest-prefix PascalCase test names (TestStore_PersistsMultipleSessionsAcrossRestart) with plain intent phrases written in the project's own naming convention; generalize-raceto "whatever race/thread detector the toolchain provides"; swapnil/slicefor "absent"/"collection".planning-a-feature: droppanic("unimplemented"), "Go signatures, TS types", and "unexported package" from the stub-realization examples in favor of stack-neutral phrasing.Testing
No behavior or control flow changed — only illustrative prose. Verified by re-running the language-leakage grep across all skill bodies (now clean of Go-convention prescriptions; remaining hits are idioms like "slice of the problem" and generic unit terms like "package") and reading the diff cold to confirm each principle stayed intact.