Skip to content

fix: ignore stale ticket detail responses in Tickets page #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sonnymay wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: ignore stale ticket detail responses in Tickets page #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions frontend/src/pages/Tickets.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useState } from "react";
import { useEffect, useRef, useState } from "react";
import { api } from "../api";
import AISuggestions from "../components/AISuggestions";
import { LoadingState, ErrorState, InlineError } from "../components/AsyncState";
Expand Down Expand Up @@ -42,6 +42,9 @@ export default function Tickets() {
const [detailLoading, setDetailLoading] = useState(false);
const [saving, setSaving] = useState(false);
const [noteSaving, setNoteSaving] = useState(false);
// Identifies the most recent detail request so a slow response for a
// previously clicked ticket can't overwrite the currently selected one.
const detailRequestRef = useRef(0);

const load = async () => {
setLoading(true);
Expand All @@ -63,6 +66,7 @@ export default function Tickets() {
};

const loadDetail = async (t) => {
const requestId = ++detailRequestRef.current;
setSelected(t);
setDetailError(null);
setDetailLoading(true);
Expand All @@ -73,12 +77,14 @@ export default function Tickets() {
api.get(`/tickets/${t.id}/notes`),
api.get(`/tickets/${t.id}/history`),
]);
if (requestId !== detailRequestRef.current) return;
setNotes(ticketNotes);
setHistory(ticketHistory);
} catch (e) {
if (requestId !== detailRequestRef.current) return;
setDetailError(e.message || String(e));
} finally {
setDetailLoading(false);
if (requestId === detailRequestRef.current) setDetailLoading(false);
}
};

Expand Down
Loading