Repository navigation
Conversation
If the model returned valid JSON that wasn't an object with a list under
"matches" (e.g. {"matches": null} or a bare list), suggest_for_ticket
raised and /ai/suggest returned a 500. It now returns an empty match list
with an error, like the existing non-JSON case.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0171zWzjpbovQSMUdE4PmH6R
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ai.suggest_for_ticketonly handled non-JSON model output. If the model returned valid JSON that didn't match the schema ({"matches": null}, a bare list,"matches"as a string), the slice or.getraised and/ai/suggestreturned a 500. It now returns{"matches": [], "raw": ..., "error": "Model returned an unexpected response shape"}, matching the existing non-JSON path.Distinct from the open
ai.pyPRs: #20–#42 (escaping), #59 (note batching), #67 (exclude self from history) and #51 (generic 500 message). None touch response parsing.Testing
backend/test_ai_response.py(loads the realaimodule, sincetest_main.pystubs it): four malformed payloads, and the 3-match cap.pytest: 48 passed (withSUPABASE_URL/SUPABASE_KEYset);ruff checkandruff format --checkclean.Generated by Claude Code