Claude/ci jobs failing xxrsmg

.claude/settings.json

@@ -0,0 +1,15 @@
+{
+  "hooks": {
+    "SessionStart": [
+      {
+        "matcher": "startup|resume",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "bash \"$CLAUDE_PROJECT_DIR\"/deploy/linux/cloud-session.sh start --if-cloud"
+          }
+        ]
+      }
+    ]
+  }
+}

.github/copilot-instructions.md

@@ -0,0 +1,19 @@
+# Copilot instructions
+
+The instructions for AI agents in this repository are in [`AGENTS.md`](../AGENTS.md) at
+the repository root, and the documentation they point to is in [`docs/`](../docs/). Read
+`AGENTS.md` first and follow it; this file exists only so that tools which look here find
+their way there.
+
+The essentials, for a context that cannot follow the link:
+
+- Fork of Tony (Qt6 / C++17, meson + ninja, Sonic Visualiser libraries) adding singing
+  practice features. The fork's own code is in `main/`; tests are in `main/test/`.
+- Build from Git Bash with
+  `export PATH="/c/msys64/mingw64/bin:$PATH" MINGW_PREFIX="C:/msys64/mingw64"` and
+  `ninja -j 3 -C build_mingw Tony.exe test-tony-core.exe test-tony-app.exe`, logging to a
+  file under `tmp/`. From PowerShell use `.\build.bat` and `.\build.bat test`.
+- `svcore/`, `svgui/`, `svapp/` and the other top-level library directories are separate,
+  gitignored repositories. See `docs/forks.md` before changing one.
+- Match the surrounding code, keep changes in scope, and give every behaviour a test that
+  can fail.

.github/workflows/android.yml

@@ -0,0 +1,94 @@
+name: Android CI
+
+on: [push, pull_request]
+
+# The APK, built by the scripts in deploy/android/ as the cloud container
+# builds it (docs/building.md). Qt for Android and the C libraries are
+# built from source there, which takes most of an hour: each is cached,
+# keyed on the script that builds it and the toolchain's, and saved as
+# soon as it is built, so that a later step's failure does not cost it
+
+env:
+  # The runner's own SDK and NDK are other versions; everything that
+  # looks for one in the environment is to find the scripts'
+  ANDROID_HOME: /opt/android/sdk
+  ANDROID_SDK_ROOT: /opt/android/sdk
+  ANDROID_NDK: /opt/android/sdk/ndk/27.2.12479018
+  ANDROID_NDK_HOME: /opt/android/sdk/ndk/27.2.12479018
+  ANDROID_NDK_ROOT: /opt/android/sdk/ndk/27.2.12479018
+  ANDROID_NDK_LATEST_HOME: /opt/android/sdk/ndk/27.2.12479018
+
+jobs:
+  build:
+
+    runs-on: ubuntu-24.04
+
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        # build-apk.sh counts the commits for the version code
+        fetch-depth: 0
+    # The runner's own Android SDK and .NET take disk the Qt build needs
+    - name: free-disk
+      run: |
+        df -h /
+        sudo rm -rf /usr/local/lib/android /usr/share/dotnet /opt/ghc /usr/local/.ghcup
+        df -h /
+    - name: prepare
+      run: |
+        sudo mkdir -p /opt/android
+        sudo chown "$(id -u):$(id -g)" /opt/android
+    - name: install-packages
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y git mercurial smlnj
+    - name: repoint
+      run: ./repoint install
+    - name: setup-toolchain
+      run: deploy/android/setup-toolchain.sh
+    - name: restore-qt
+      id: qt
+      uses: actions/cache/restore@v4
+      with:
+        path: /opt/android/qt
+        key: android-qt-${{ hashFiles('deploy/android/build-qt.sh', 'deploy/android/setup-toolchain.sh') }}
+    - name: build-qt
+      run: deploy/android/build-qt.sh
+    - name: save-qt
+      if: steps.qt.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        path: /opt/android/qt
+        key: ${{ steps.qt.outputs.cache-primary-key }}
+    - name: restore-deps
+      id: deps
+      uses: actions/cache/restore@v4
+      with:
+        path: /opt/android/deps-arm64-v8a
+        key: android-deps-${{ hashFiles('deploy/android/build-deps.sh', 'deploy/android/setup-toolchain.sh') }}
+    - name: build-deps
+      run: deploy/android/build-deps.sh
+    - name: save-deps
+      if: steps.deps.outputs.cache-hit != 'true'
+      uses: actions/cache/save@v4
+      with:
+        path: /opt/android/deps-arm64-v8a
+        key: ${{ steps.deps.outputs.cache-primary-key }}
+    - name: build-tony
+      run: deploy/android/build-tony.sh
+    - name: build-apk
+      run: deploy/android/build-apk.sh
+    - name: upload-apk
+      uses: actions/upload-artifact@v4
+      with:
+        name: Tony-debug-apk
+        path: build-android/apk/Tony-debug.apk
+        if-no-files-found: error
+    # The scripts show the end of a failing log; the whole of each is here
+    - name: upload-logs
+      if: failure()
+      uses: actions/upload-artifact@v4
+      with:
+        name: android-logs
+        path: /opt/android/logs
+        if-no-files-found: ignore

.github/workflows/linux.yml

@@ -5,21 +5,21 @@ on: [push, pull_request]
 jobs:
   build:
 
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
     - uses: actions/checkout@v2
     - name: install-packages
       run: |
         sudo apt-get update
-        sudo apt-get install build-essential libbz2-dev libfftw3-dev libfishsound1-dev libid3tag0-dev liblo-dev liblrdf0-dev libmad0-dev liboggz2-dev libopus-dev libopusfile-dev libpulse-dev libsamplerate-dev libsndfile-dev libsord-dev libxml2-utils portaudio19-dev qt6-base-dev qt6-pdf-dev qt6-base-dev-tools libqt6svg6-dev raptor2-utils git mercurial autoconf automake libtool smlnj capnproto libcapnp-dev ninja-build libglib2.0-dev libboost-all-dev
+        sudo apt-get install build-essential libbz2-dev libfftw3-dev libfishsound1-dev libid3tag0-dev liblo-dev liblrdf0-dev libmad0-dev liboggz2-dev libopus-dev libopusfile-dev libpulse-dev libsamplerate0-dev libsndfile1-dev libsord-dev libxml2-utils portaudio19-dev qt6-base-dev qt6-pdf-dev qt6-base-dev-tools qt6-svg-dev raptor2-utils git mercurial autoconf automake libtool smlnj capnproto libcapnp-dev ninja-build libglib2.0-dev libboost-all-dev
     - name: install-meson
       run: |
         mkdir -p tmp/meson
         cd tmp/meson
         wget https://github.com/mesonbuild/meson/releases/download/1.3.1/meson-1.3.1.tar.gz
         tar xvf meson-1.3.1.tar.gz
-        sudo ln -s $(pwd)/meson-1.3.1/meson.py /usr/bin/meson
+        sudo ln -sf $(pwd)/meson-1.3.1/meson.py /usr/bin/meson
     - name: install-rubberband
       run: |
         mkdir -p tmp/rubberband
@@ -33,10 +33,21 @@ jobs:
     - name: repoint
       run: ./repoint install
     - name: configure
-      run: |
-        qtchooser -install qt6 $(which qmake6)
-        QT_SELECT=qt6 meson setup build --buildtype release
+      run: meson setup build --buildtype release
     - name: make
       run: ninja -C build
     - name: test
-      run: meson test -C build
+      id: test
+      run: meson test -C build --print-errorlogs --num-processes 1
+    # meson shows at most the last 100 lines of a failing log, and one
+    # test executable runs several QTest suites: name every failed test,
+    # with the lines QTest indents under it (compared values, where it
+    # failed) and the totals of each suite that failed
+    - name: test-failures
+      if: failure() && steps.test.outcome == 'failure'
+      run: |
+        awk '/^test:/ { print; next }
+             /^Totals:/ { if ($0 !~ /, 0 failed/) print; next }
+             /^(FAIL!|XPASS|QFATAL)|Received signal/ { print; fail = 1; next }
+             /^[A-Z!]+ *: / { fail = 0 }
+             fail && /^   / { print }' build/meson-logs/testlog.txt

.github/workflows/macos.yml

@@ -18,12 +18,23 @@ jobs:
     - name: make
       run: ninja -C build
     - name: test
-      run: meson test -C build
-    - name: deploy-app
+      id: test
+      run: meson test -C build --print-errorlogs --num-processes 1
+    # meson shows at most the last 100 lines of a failing log, and one
+    # test executable runs several QTest suites: name every failed test,
+    # with the lines QTest indents under it (compared values, where it
+    # failed) and the totals of each suite that failed
+    - name: test-failures
+      if: failure() && steps.test.outcome == 'failure'
       run: |
-        ls -lR /usr/local/opt
-        QTDIR=/usr/local/opt/qt6 ./deploy/macos/deploy.sh "Tony"
+        awk '/^test:/ { print; next }
+             /^Totals:/ { if ($0 !~ /, 0 failed/) print; next }
+             /^(FAIL!|XPASS|QFATAL)|Received signal/ { print; fail = 1; next }
+             /^[A-Z!]+ *: / { fail = 0 }
+             fail && /^   / { print }' build/meson-logs/testlog.txt
+    # No app bundle: the packaging scripts in deploy/osx are qmake's,
+    # and this build makes none. The app it does build has to start
     - name: check
       run: |
-        otool -L ./"Tony.app/Contents/MacOS/Tony"
-        ./"Tony.app/Contents/MacOS/Tony" --version
+        otool -L build/tony
+        build/tony --version

.github/workflows/windows.yml

@@ -2,54 +2,100 @@ name: Windows CI
 
 on: [push, pull_request]
 
+# Built as it is on the development machine (docs/building.md): MSYS2's
+# mingw64 toolchain, Qt and libraries, with meson and ninja
+
 jobs:
   build:
 
-    runs-on: windows-2019
+    runs-on: windows-2022
 
     steps:
     - uses: actions/checkout@v3
     - uses: ProjectSavanna/setup-sml@v1.2.0
       with:
         smlnj-version: '110.99.4'
-    - uses: actions/setup-python@v1
-      with:
-        python-version: '3.x'
-    - uses: jurplel/install-qt-action@v3
-      with:
-        version: '6.6.1'
-        host: 'windows'
-        target: 'desktop'
-        arch: 'win64_msvc2019_64'
-    - uses: MarkusJx/install-boost@v2.4.5
-      id: install-boost
-      with:
-        boost_version: 1.84.0
-        platform_version: 2019
-        toolset: msvc
-    - uses: ilammy/msvc-dev-cmd@v1
-      with:
-        vsversion: '2019'
 
-    - name: install-meson
-      run: pip install meson ninja
+    # repoint checks six of the libraries out with Mercurial
+    - name: mercurial
+      run: if (-not (Get-Command hg -ErrorAction SilentlyContinue)) { pip install mercurial }
 
     - name: repoint
       run: ./repoint install
 
-    - name: configure
-      run: meson setup build --buildtype release
-      env:
-        BOOST_ROOT: ${{ steps.install-boost.outputs.BOOST_ROOT }}
+    - uses: msys2/setup-msys2@v2
+      with:
+        msystem: MINGW64
+        update: true
+        install: >-
+          mingw-w64-x86_64-gcc
+          mingw-w64-x86_64-meson
+          mingw-w64-x86_64-ninja
+          mingw-w64-x86_64-pkgconf
+          mingw-w64-x86_64-qt6-base
+          mingw-w64-x86_64-qt6-svg
+          mingw-w64-x86_64-boost
+          mingw-w64-x86_64-bzip2
+          mingw-w64-x86_64-zlib
+          mingw-w64-x86_64-fftw
+          mingw-w64-x86_64-libsamplerate
+          mingw-w64-x86_64-rubberband
+          mingw-w64-x86_64-libsndfile
+          mingw-w64-x86_64-flac
+          mingw-w64-x86_64-libogg
+          mingw-w64-x86_64-libvorbis
+          mingw-w64-x86_64-opus
+          mingw-w64-x86_64-opusfile
+          mingw-w64-x86_64-libmad
+          mingw-w64-x86_64-libid3tag
+          mingw-w64-x86_64-portaudio
+          mingw-w64-x86_64-serd
+          mingw-w64-x86_64-sord
 
-    - name: copy-qt-etc
+    # meson.build reads MINGW_PREFIX, which an MSYS2 shell sets to the
+    # POSIX path /mingw64: gcc wants the Windows one. Every step sets it,
+    # as ninja may run meson again
+    - name: configure
+      shell: msys2 {0}
       run: |
-          foreach ($lib in 'Core','Gui','Widgets','Network','Xml','Svg','Test') { copy "..\Qt\6.6.1\msvc2019_64\bin\Qt6$lib.dll" build }
-          cp sv-dependency-builds\win64-msvc\lib\libsndfile-1.dll build
+        export MINGW_PREFIX=$(cygpath -m /mingw64)
+        meson setup build --buildtype release
 
-    - name: build
-      run: ninja -C build
+    - name: make
+      shell: msys2 {0}
+      run: |
+        export MINGW_PREFIX=$(cygpath -m /mingw64)
+        ninja -C build
 
+    # Tony's suites also write their results to files: here QTest's
+    # output to stdout does not reach meson's log
     - name: test
-      run: meson test -C build
-
+      id: test
+      shell: msys2 {0}
+      run: |
+        export MINGW_PREFIX=$(cygpath -m /mingw64)
+        mkdir -p build/test-results
+        export TONY_TEST_LOG_DIR=$(cygpath -m "$PWD/build/test-results")
+        meson test -C build --print-errorlogs --num-processes 1
+    # meson shows at most the last 100 lines of a failing log, and one
+    # test executable runs several QTest suites: name every failed test,
+    # with the lines QTest indents under it (compared values, where it
+    # failed) and the totals of each suite that failed
+    - name: test-failures
+      if: failure() && steps.test.outcome == 'failure'
+      shell: msys2 {0}
+      run: |
+        awk '/^test:/ { print; next }
+             /^Totals:/ { if ($0 !~ /, 0 failed/) print; next }
+             /^(FAIL!|XPASS|QFATAL)|Received signal/ { print; fail = 1; next }
+             /^[A-Z!]+ *: / { fail = 0 }
+             fail && /^   / { print }' build/meson-logs/testlog.txt
+        awk 'function show(line) {
+                 if (!shown) { print "suite: " FILENAME; shown = 1 }
+                 print line
+             }
+             FNR == 1 { shown = 0; fail = 0 }
+             /^Totals:/ { if ($0 !~ /, 0 failed/) show($0); next }
+             /^(FAIL!|XPASS|QFATAL)/ { show($0); fail = 1; next }
+             /^[A-Z!]+ *: / { fail = 0 }
+             fail && /^   / { show($0) }' build/test-results/*.txt

.gitignore

@@ -34,9 +34,12 @@ chp
 pyin
 glob:.repoint*
 build
+build-android
+build-linux-ci
 build_win32
 build_win64
 build_win64_debug
+build_linux
 *.AppImage
 *.AppDir
 Dockerfile*.gen
@@ -49,4 +52,8 @@ test-svcore-*
 *.dmg
 .notarization-uuid
 Dockerfile*.gen
-
+tmp
+# Claude Code's local files (settings.local.json, worktrees); only the
+# shared settings, with the cloud session's hook, are tracked
+.claude/*
+!.claude/settings.json