Repository navigation
Conversation
Signed-off-by: song <liusongstep@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to the upstream repository
This proposal has been resubmitted as loopx-project/loopx#7778, targeting upstream
main, with the same head commit90d7d460b010777b583bec0ab8327a843cfa0202.Closing this fork-local PR to keep further review in the upstream submission. No implementation commit was changed by this move. The upstream description records the old loopx-project#7764 dependency, the newer loopx-project#7764 recovery policy, and the integration decision still needed before merge. The original discussion and validation record remain below.
Contribution target
Contribution for loopx-project/loopx#7764. The base branch is an unchanged snapshot of its
c053027fb2f26c54cc3f5950ebee7021e87a5450head; this PR contains only the four-file follow-up, ready to cherry-pick as one commit. The GitHub integration cannot open a PR in the original author's fork (HTTP 403), so this reviewable contribution is hosted here and linked from the upstream discussion.Problem
This is a focused follow-up to loopx-project#7764, based on its
c053027fb2f26c54cc3f5950ebee7021e87a5450head. It is intended for that contribution branch, so the review contains only the recovery fix below.Source-history reconciliation selects the latest event for each missing, already registered result. The stricter attribution checks correctly reject new measurements that contradict their declared execution. However, reconciliation preview currently counts contradictory historical events as recoverable, then execution rejects the entire batch, including valid results.
A synthetic real-CLI case with one valid finding and two historical attribution contradictions previews three recoveries on the base revision, then fails before writing any of them.
Change and behavior
blockedwhen no selected record is writable. Partial recovery reportswould_reconcile_with_blocked_historyorreconciled_with_blocked_history.Validation
Tested tree:
712bc48c58c3091611f9fb11a194d42b7e5161e2.The following four focused modules passed: 57 tests.
Coverage includes mixed and all-blocked recovery, unrelated remote orphans, corrected latest events, idempotence, forged/unknown/private source rejection before any write, runtime failure propagation, the existing strict-write and archival-history contracts, and actual CLI JSON/Markdown preview, execution, and readback. The CLI test first verifies the uninstalled-extension rejection, then installs the bundled Lark provider through its real local lifecycle; it does not bypass the gate or call a remote service.
The same isolated real-CLI harness and synthetic fixture were run against the base and tested candidate:
blocked, writes 0The acceptance oracle fails on the base and passes on the candidate. Both isolated runtimes were stopped after authenticated ownership checks.
Also passed: focused Ruff, changed-source semantic advisory, public-boundary scan of all four changed files, staged bilingual RFC check, and
git diff --check. The semantic advisory does not infer dynamically constructed status strings; the additive recovery statuses are explicitly described above. Full repository CI and merge readiness remain separate qualification.Scope and generality
The bounded refactor exposes the existing attribution validator to its real recovery caller; it adds no parallel measurement owner or generic recovery framework. The tests use synthetic opaque references and exercise the result-reference and input-revision contracts, not task names, benchmark values, model identities, or a provider-specific rule. This change makes no claim about benchmark scores, token savings, performance, or downstream research outcomes.