Skip to content

Address Codex review findings #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somoore merged 1 commit into from
Nov 3, 2026
Merged

Address Codex review findings #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,10 @@ aws_account_id = "$ACCOUNT_ID"
EOF
say "Wrote $HOME_DIR/config.toml"

# CLI.
# CLI. Export HELLBOX_HOME so the CLI reads the config this script just wrote:
# without it, a legacy LAMBDADOOM_HOME still exported from an old install would
# make the CLI resolve the old ~/.lambdadoom config/state instead of this one.
export HELLBOX_HOME="$HOME_DIR"
HELLBOX="$(resolve_hellbox)"
say "Using hellbox CLI: $HELLBOX"

Expand Down
6 changes: 4 additions & 2 deletions uninstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,11 @@ remove_local_home(){

# Stop a running loopback proxy (`hellbox open`) if one is still up — uninstall
# should be self-contained whether or not the user Ctrl-C'd it first. Targets only
# the hellbox proxy by command pattern; harmless if none is running.
# the hellbox/ldoom proxy by command pattern; harmless if none is running.
# Legacy LambdaDoom installs still run the proxy as `ldoom open`, so match both
# binary names (-f scans the full command line).
if command -v pkill >/dev/null 2>&1; then
if pkill -f 'hellbox(\.exe)? open' 2>/dev/null; then
if pkill -f '(hellbox|ldoom)(\.exe)? open' 2>/dev/null; then
say "Stopped the running hellbox proxy"
fi
fi
Expand Down
Loading