Repository navigation
Update Go toolchain for TLS fix - #39
Merged
Merged
Conversation
Owner
Author
|
@codex review Please review the Go security update and the historical-remediation evidence in the PR description. If there are no findings, react with or reply explicitly with 👍 so this can be merged. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed\n- update the Go toolchain directive from 1.26.4 to 1.26.5\n\n## Why\nThe repository's required make test gate now reports reachable GO-2026-5856 in Go 1.26.4 crypto/tls. Go 1.26.5 contains the fix.\n\nAs part of the closed-PR audit, current main was also rechecked against the historical Codex feedback from PRs #23/#24 and #35/#36:\n- the POSIX installer verifies that /dev/tty can actually be opened\n- Windows release archives and install paths use cmesh.exe\n- doctor uses independent runner and Tailscale contexts\n- PATH-resolved runners are accepted outside service diagnostics\n- Windows danger-full-access requires explicit operator opt-in\n\n## Validation\n- GOTOOLCHAIN=go1.26.5 make test — pass\n- govulncheck — 0 reachable vulnerabilities\n- go test ./... — pass\n- go build -trimpath -o /tmp/cmesh ./cmd/cmesh — pass\n- git diff --check — pass