Skip to content

fix: 지원 대학 필수 컬럼 검증 조건 수정#559

Merged
whqtker merged 1 commit into
mainfrom
fix/univ-apply-info-required-fields
Jun 18, 2026
Merged

fix: 지원 대학 필수 컬럼 검증 조건 수정#559
whqtker merged 1 commit into
mainfrom
fix/univ-apply-info-required-fields

Conversation

@whqtker

@whqtker whqtker commented Jun 18, 2026

Copy link
Copy Markdown
Member

변경 사항

  • 지원 대학 마크다운 import의 항상 필수 필드를 대학명 (국문)만으로 조정했습니다.
  • 국가, 대학명 (영문), 선발 인원, 파견 가능 학기, 최저 이수학기, 최저 성적요건, 성적 기준, 어학 세부 요건, 기숙사는 값이 없을 때 클라이언트 검증에서 막지 않도록 했습니다.
  • 값이 입력된 선택 필드는 기존처럼 타입/형식 제약을 검증하는 테스트를 추가했습니다.
  • 언어 시험 컬럼은 빈 값이어도 import를 막지 않는 테스트를 추가했습니다.

원인

기존 필드 메타데이터의 required 값이 DB/import 로직상 nullable 또는 조건부 필수인 필드까지 항상 필수로 표시하고 있어, 실제 저장 가능한 마크다운 행도 클라이언트에서 차단했습니다.

검증

  • pnpm --filter @solid-connect/admin test -- src/components/features/univ-apply-infos/univApplyInfoValidation.test.ts src/components/features/univ-apply-infos/univApplyInfoFields.test.ts
  • pnpm --filter @solid-connect/admin test -- src/components/features/univ-apply-infos
  • pnpm --filter @solid-connect/admin typecheck
  • pnpm --filter @solid-connect/admin lint:check
  • commit/push hook의 @solid-connect/admin ci:check
  • push hook의 @solid-connect/admin build

현재 로컬 Node.js는 v24.14.0이라 프로젝트 요구사항 22.x 경고가 출력됐지만, 위 검증은 모두 통과했습니다.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jun 18, 2026 7:59am
solid-connect-web-admin Ready Ready Preview, Comment Jun 18, 2026 7:59am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connection-web Skipped Skipped Jun 18, 2026 7:59am

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@whqtker, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 48 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b073a582-5eb1-4f26-8de2-9a1d5993d441

📥 Commits

Reviewing files that changed from the base of the PR and between d35d112 and 1492b70.

📒 Files selected for processing (3)
  • apps/admin/src/components/features/univ-apply-infos/univApplyInfoFields.test.ts
  • apps/admin/src/components/features/univ-apply-infos/univApplyInfoFields.ts
  • apps/admin/src/components/features/univ-apply-infos/univApplyInfoValidation.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/univ-apply-info-required-fields

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the admin label Jun 18, 2026
@whqtker whqtker changed the title 지원 대학 필수 컬럼 검증 조건 수정 fix: 지원 대학 필수 컬럼 검증 조건 수정 Jun 18, 2026
@whqtker whqtker self-assigned this Jun 18, 2026
@whqtker whqtker merged commit 3f979d8 into main Jun 18, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant