fix: 커뮤니티 기본 썸네일 숨김#557
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review getPostThumbnailSrc |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@coderabbitai getPostThumbnailSrc로 동작이 달라질수 있습니까 ? |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
fd "PostCards.tsx" --exec cat {}Length of output: 4820 🏁 Script executed: #!/bin/bash
fd "cdnUrl" --exec cat {}Length of output: 10427
✅ 정상적으로 필터링되는 케이스
|
| 케이스 | 동작 |
|---|---|
| 일반 CDN 이미지 URL | ✅ 정상 표시 |
/images/article-thumb.png 계열 |
✅ 정상 필터링 |
/svgs/placeholders/ 계열 |
✅ 정상 필터링 |
| 대소문자 다른 경로 | |
| 외부 도메인 + 동일 path |
가장 주의할 점은 대소문자 처리입니다. 서버 응답이 항상 소문자라면 현재 코드로 충분하지만, 확실히 하려면 thumbnailPathname.toLowerCase()로 비교하는 것을 권장드립니다! 🐇
관련 이슈
작업 내용
/images/article-thumb.png,/images/site-thumbnail.png, placeholder svg 등)를 내려주는 경우도 실제 게시글 이미지가 아닌 것으로 보고 숨기도록 방어했습니다.min-w-0 flex-1을 적용했습니다.특이 사항
22.x와 달라Unsupported engine경고가 출력되지만 검증은 통과했습니다.리뷰 요구사항 (선택)
검증
pnpm --filter @solid-connect/web lint:checkpnpm --filter @solid-connect/web typecheck:ci@solid-connect/web build통과