Fix/community write login redirect#556
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough이 PR은 인증 후 사용자가 원래 보고 있던 커뮤니티 경로로 돌아가는 리다이렉트 기능을 전체 로그인·회원가입 흐름에 걸쳐 추가합니다. 1. 리다이렉트 유틸 및 타입 정의 2. OAuth 및 인증 훅 시그니처 변경 3. 로그인 페이지 redirectPath 추출 및 전파 4. OAuth 콜백 페이지에서 redirectPath 수신 5. 회원가입 플로우에 redirectPath 반영 6. 커뮤니티 글쓰기 진입 시 인증 가드 추가 7. 로딩 UI 통일 Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25분 Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/components/login/signup/SignupSurvey.tsx`:
- Around line 33-37: The router.push call on line 35 is being executed during
the render phase, which can cause re-render loops and warnings, and allows the
component to continue rendering with invalid state before navigation completes.
Move the signUpToken validation and router.push navigation into a useEffect hook
that depends on signUpToken, ensuring navigation happens after the render phase
and preventing the rest of the component logic from executing when the token is
missing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: da0b6a47-9326-4277-95aa-d3fdd359d084
📒 Files selected for processing (18)
apps/web/src/apis/Auth/api.tsapps/web/src/apis/Auth/postAppleAuth.tsapps/web/src/apis/Auth/postEmailLogin.tsapps/web/src/apis/Auth/postKakaoAuth.tsapps/web/src/app/community/[boardCode]/CommunityPageContent.tsxapps/web/src/app/community/[boardCode]/create/PostForm.tsxapps/web/src/app/login/LoginContent.tsxapps/web/src/app/login/apple/callback/AppleLoginCallbackPage.tsxapps/web/src/app/login/apple/callback/page.tsxapps/web/src/app/login/kakao/callback/KakaoLoginCallbackPage.tsxapps/web/src/app/login/kakao/callback/page.tsxapps/web/src/app/login/page.tsxapps/web/src/app/sign-up/email/EmailSignUpForm.tsxapps/web/src/app/sign-up/email/page.tsxapps/web/src/app/sign-up/page.tsxapps/web/src/components/login/signup/SignupSurvey.tsxapps/web/src/utils/authRedirect.tsapps/web/src/utils/authUtils.ts
작업 내용