fix: english_name UK 제거#771
Merged
Merged
Conversation
whqtker
requested review from
Hexeong,
JAEHEE25,
lsy1307,
sukangpunch and
wibaek
as code owners
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 846fac3a95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
whqtker
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java (1)
279-285: ⚡ Quick win1) 성공 케이스 전환은 좋고, 저장 상태 검증까지 추가하면 회귀 방지가 더 단단해집니다.
두 테스트 모두 응답 DTO만 확인하고 있어, 나중에 서비스가 조회/매핑 방식으로 바뀌면 의도와 다른 동작도 통과할 수 있습니다.
create는 신규 ID 생성/레코드 수 증가(또는 중복 englishName 행 존재),update는 DB 재조회 후englishName반영까지 함께 검증해 주세요.Also applies to: 389-395
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java` around lines 279 - 285, The test cases for createHostUniversity and updateHostUniversity (the second location at lines 389-395) are only validating the response DTO but not verifying that the data was actually persisted to the database. Enhance both tests by adding persistence verification: for createHostUniversity, verify that a new ID was generated and the database record count increased (or query to confirm the new record exists with the provided englishName); for updateHostUniversity, re-query the database after the update call and verify that the englishName field was actually persisted with the updated value. This ensures the service correctly saves changes and prevents regressions if the implementation is refactored to return mapped DTOs without persisting them.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@src/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java`:
- Around line 279-285: The test cases for createHostUniversity and
updateHostUniversity (the second location at lines 389-395) are only validating
the response DTO but not verifying that the data was actually persisted to the
database. Enhance both tests by adding persistence verification: for
createHostUniversity, verify that a new ID was generated and the database record
count increased (or query to confirm the new record exists with the provided
englishName); for updateHostUniversity, re-query the database after the update
call and verify that the englishName field was actually persisted with the
updated value. This ensures the service correctly saves changes and prevents
regressions if the implementation is refactored to return mapped DTOs without
persisting them.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3bb91340-5fcf-49bf-b9a7-0f2be2951736
📒 Files selected for processing (6)
src/main/java/com/example/solidconnection/admin/university/service/AdminHostUniversityService.javasrc/main/java/com/example/solidconnection/university/domain/HostUniversity.javasrc/main/java/com/example/solidconnection/university/repository/HostUniversityRepository.javasrc/main/resources/db/migration/V52__add_unique_constraint_to_host_university_english_name.sqlsrc/main/resources/db/migration/V52__extend_univ_apply_info_import_columns.sqlsrc/test/java/com/example/solidconnection/admin/service/AdminHostUniversityServiceTest.java
💤 Files with no reviewable changes (3)
- src/main/resources/db/migration/V52__add_unique_constraint_to_host_university_english_name.sql
- src/main/java/com/example/solidconnection/admin/university/service/AdminHostUniversityService.java
- src/main/java/com/example/solidconnection/university/repository/HostUniversityRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
english_name 에 대한 UK 설정 삭제합니다.
특이 사항
리뷰 요구사항 (선택)