fix: 헬스체크 grep 쿼팅 버그 수정#758
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Walkthrough
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
SSH 단일 인용부호 내부에서
'"status":"UP"'패턴이 올바르게 전달되지 않는 쉘 쿼팅 버그를 수정합니다.문제
SSH 명령이 single-quote로 감싸진 상태에서 내부의
'"status":"UP"'가 파싱될 때, bash가 single-quote를 닫았다 열면서grep -o status:UP으로 해석됩니다.{"status":"UP"}응답에서status:UP은 매칭되지 않아 헬스체크가 항상 실패했습니다.변경 내용
grep -o '"status":"UP"'방식 → HTTP 상태코드 확인 방식으로 변경Spring Boot는 상태가 UP이면 HTTP 200, DOWN이면 503을 반환하므로 상태코드로 판단합니다.
변경 파일:
.github/workflows/dev-cd.yml,.github/workflows/prod-cd.yml특이 사항
%{http_code}는 single-quote 내부에서도 올바르게 전달됨리뷰 요구사항 (선택)