Repository navigation
Upgrade to Brine-ed25519 0.10.0 - #99
Merged
Merged
Conversation
Add test for non-standard encodings not rejected by 0.7.0
mcintyre94
commented
Oct 28, 2026
| // Verify the signer signed the authorization message | ||
| brine_ed25519::verify::<Sha512>(signer, signature.as_array(), &[message_bytes.as_slice()]) | ||
| .map_err(|_| Error::InvalidSignature)?; | ||
| brine_ed25519::verify_with_hasher_strict::<Sha512>( |
Member
Author
There was a problem hiding this comment.
In 0.10.0 we need to use verify_with_hasher_strict instead of verify to get these checks, API is otherwise the same
joncinque
approved these changes
Oct 28, 2026
joncinque
left a comment
joncinque
left a comment
Contributor
There was a problem hiding this comment.
Looks great! We can start with this, and move to a relaxed version later, since SIMD-0376 will remove strict verification in the validator: https://github.com/solana-foundation/solana-improvement-documents/blob/main/proposals/0376-verify-strict.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test for non-standard encodings not rejected by 0.7.0
Closes #97
Also includes the audit fix from #98 in the Lockfile, so this supersedes that if merged first