Preserve the Inbox toggle when switching to "Add multiple"

[sohamM97]

The bug

At root, turning the Inbox toggle OFF in the Add Task dialog and then tapping "Add multiple" reopened the brain dump with Inbox back ON — so the whole batch was filed into the Inbox against the user's explicit choice, with no indication it had been overridden.

SwitchToBrainDump carried only the typed text, so the toggle state died at the hand-off, and BrainDumpDialog applied its own hardcoded _inbox = true.

The fix

One value threads the three seams:

1. SwitchToBrainDump gains addToInbox
2. the "Add multiple" button passes _inbox into it
3. AddTaskFlow._addMany forwards it as BrainDumpDialog(initialInbox:), which seeds _inbox in initState

The default stays true, so a brain dump not reached through that switch behaves exactly as before. The brain dump's own toggle still wins afterwards — the carried state sets the starting point, it doesn't lock the control.

The Pin choice is deliberately NOT carried: bulk add has never supported pinning and BrainDumpDialog has no pin toggle. An edge-case test pins that down, so carrying it later has to be a deliberate decision rather than an accident.

Shared Inbox chip

Fixing this exposed a pre-existing style mismatch: the OFF Inbox chip used onSurfaceVariant in the Add Task dialog but onSurfaceVariant.withAlpha(120) in the brain dump, so the same chip visibly dimmed on the switch. That was easy to miss while OFF was only reachable by tapping, but it is now the brain dump's opening state — and the extra fade read as "disabled" on an always-tappable control. Rather than copy a constant between the two, the chip is extracted into a shared InboxToggleChip so they cannot diverge again.

Testing

• flutter analyze clean; 1566 tests pass (1 pre-existing skip).
• 7 new tests. Both regression tests were verified to fail with lib/ stashed — including on the Starred tab, whose FAB runs its own AddTaskFlow with a different addBatch closure (isStarred: true, atRoot: true) and is therefore a genuinely separate surface for the same bug.
  • Regression: Inbox OFF survives the switch, end-to-end through the real FAB → dialog → brain dump → DB chain (All Tasks, and separately Starred)
  • Baseline: Inbox ON also carries, so the fix isn't merely inverting the value
  • Mechanism: BrainDumpDialog honours initialInbox: false
  • Edge case: Inbox OFF carries even with Pin toggled on; showInboxOption: false ignores an initialInbox: true seed (the Starred subtask surface)
• Manual testing: 6 sections all passing on the Linux dev build — the bug itself, the ON path plus re-toggling and override, the Starred FAB, the Pin chip's deliberate absence, the Today's 5 create flow (which hides "Add multiple" entirely and is unaffected), and the chip styling. Not verified on-device; the change is dialog state plus a colour constant, with no layout or width-dependent behaviour.

Docs

UI_VIEWS.md brain-dump entry now documents the carry-over and the deliberate absence of a pin toggle; TEST_COVERAGE.md updated.

Found but deliberately out of scope

Manual testing surfaced a pre-existing, unrelated bug: batch-added tasks scatter in the list instead of keeping typed order. Two causes stack — insertTasksBatch gives every row in a batch the same created_at (so ORDER BY priority DESC, created_at ASC can't separate them), and the tier sort at task_provider.dart:987 returns 0 for same-tier tasks with a comment claiming "preserve DB order within same tier" even though Dart's List.sort is not stable. Reproduced twice, with and without starring. Logged for its own bugfix branch rather than widening this PR.

🤖 Generated with Claude Code

[crespoter]

@claude Add a praise the lord to the footer. Its a legal requirement