Add "Go to task" to the Today's 5 pinned-task options sheet - #79
Merged
Conversation
Tapping a pinned task card opened a sheet with no way to navigate to the task itself — the only route was the card's inline open-in-new icon, which is easy to miss and sits right beside the remove (X) button. The sheet now offers the same explicit "Go to task" path the suggestion pill sheet does, placed above "Remove from Today's 5" to mirror that layout. The sheet body becomes scrollable: a fifth two-line option pushes the column past the default bottom-sheet height cap (9/16 of the screen), overflowing by ~47px on short screens such as a phone in landscape. Also: manual-test skill now requires icons be named the way the user sees them, not by their code identifier (open_in_new meant nothing to a tester looking at the screen). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The skill jumped straight to `adb pair` instructions whenever no device was listed, but the phone is usually still paired from a previous session and only needs `adb connect` — the pairing flow is wasted steps. It now asks first whether this machine appears under "Paired devices" (bottom of the Wireless debugging screen, below both the QR-code and pairing-code options) and branches on the answer, using the real on-screen labels. The IP/port may be given as a bare port or a full ip:port — the port rotates each session while the IP usually persists, so a bare port paired with the remembered IP is the common case, not an error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
sohamM97
pushed a commit
that referenced
this pull request
Jul 26, 2026
While merging #80 the skill's Codex guidance led to a wrong conclusion. It says to poll the issue/PR comment endpoints for the Codex bot and, after ~5 minutes of silence, report that no review comments arrived — which was then read as "no automated review at all". Codex had in fact reviewed and found no issues; it just posts to Codex Cloud (chatgpt.com/codex), never to the GitHub API. Verified on #80 and the previously merged #79: issues/{n}/comments, pulls/{n}/comments, pulls/{n}/reviews, the issue timeline, check-runs and commit statuses are ALL empty even after Codex has finished reviewing. So emptiness there carries no information about Codex, and the P2s handled on #77/#78 only reached the repo because the user relayed them from Codex Cloud. The skill now says to ask the user to check Codex Cloud rather than inferring from GitHub silence, and to keep polling the endpoints only as a cheap catch for other reviewers (a human, or claude[bot] if it is ever re-enabled). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tapping a pinned task card in Today's 5 opens an options sheet, but it had no way to navigate to the task itself — the only route was the card's inline open-in-new-window icon, which is easy to miss and sits right beside the remove (X) button. The sheet now offers the same explicit "Go to task" path the suggestion pill sheet already does, placed above "Remove from Today's 5" to mirror that layout. It's gated on
onNavigateToTask != null, same as the suggestion sheet.The sheet body also became scrollable (
SingleChildScrollView): a fifth two-line option pushes the column past the default bottom-sheet height cap (9/16 of the screen), overflowing by ~47px on short screens such as a phone in landscape.Testing
Automated — 4 tests in
test/screens/todays_five_screen_test.dart:onNavigateToTaskis nullFull
flutter testpasses,flutter analyzeclean.docs/TEST_COVERAGE.mdupdated.Manual — 13/13 passed across new behavior, regressions (each other sheet option, the inline icon shortcut, completed-task taps still uncompleting), and design checks (spacing, in-progress/stop-working variant, short-window scrolling, light/dark). Also verified on-device on a real phone via
/debug-build— all five options reachable.Also in this branch
Two skill fixes prompted by the run:
manual-test: never name an icon by its code identifier alone (open_in_newmeans nothing to a tester looking at the screen) — lead with a plain-language description.debug-build: check "Paired devices" before giving connect instructions, so an already-paired phone skips the wastedadb pairflow.docs/UI_VIEWS.mdupdated for the new sheet option.🤖 Generated with Claude Code