chore(deps)!: use non-legacy Expo FS in Resource Fetcher, bump SDK version to 56 in demo apps#1222
Conversation
|
I'll check why CI has diffs on comments in *.h files. This is definitely related to my addition to CI which suppose to check if error codes are regenerated. |
im pretty sure pre-commit does a lint, and yarn codegen:errors returns something that is not yet linted properly:) |
|
|
msluszniak
left a comment
There was a problem hiding this comment.
Actually the reason why CI fails is because you are not rebased on main, please rebase it first ;)
c1ff419 to
7cd0041
Compare
|
Can we drop the In - "@types/react": "~19.1.10",
- "react": "19.1.0",
- "react-native": "0.81.5",
+ "@types/react": "~19.2.0",
+ "react": "19.2.3",
+ "react-native": "0.85.3",I don't think the core package should move off 0.81, for a few reasons:
Could we revert just those three devDep lines and keep the SDK-56 / RN-0.85 bumps scoped to the demo apps and |
While I agree that this PR maybe is not the best place to bump it, since it involves no internal changes I think opening up another PR is frankly a waste of time. Also, I've seen Reanimated and RNGH bump to latest RN versions, so I think it might make sense to bump it. I guess it would make sense to use the latest version to keep up with eventual breaking changes as they come. |
|
Ok, as these are devDeps, we can indeed follow the latest version. Let's keep it. |
msluszniak
left a comment
There was a problem hiding this comment.
A few code-level notes from a pass over the resource-fetcher refactor (separate from the devDep comment above). All non-blocking except possibly the first, which is a genuine question about the new download API's error behavior.
8a66970 to
3c654c2
Compare


Description
This PR bumps Expo SDK to 56 across all demo apps using Expo. It also refactors the Expo Resource Fetcher to use the aforementioned version. For users using <56, a /legacy import for ExpoResourceFetcher is still available.
Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes