Repository navigation
Data Vault: keep the identity across multi-step signups and subdomains - #17
Merged
Merged
Conversation
A submit whose button was not labelled Next/Continue counted as the final
step, so Buildium's step 1 ("Start My Free Trial") marked the identity used
before step 2 loaded. A final-looking submit now marks it used only when it
carries a filled password; otherwise it is held as "finishing" and the next
page decides (more fields = keep filling, none = mark used, 30 min idle =
mark used).
The used-on filter compared exact hosts, so learn.buildium.com and
www.buildium.com were different sites: an identity used on one was offered
on the other, and step 2 dropped the active identity. Both the filter and
the active-identity store now use one site key (registrable domain, shared
hosting such as myshopify.com kept per owner).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Data Vault autofill broke on multi-step signups (reported on Buildium from the Start Links):
Fix
__sgPersonaActive('finish')); the next page (or the same page for SPA wizards) decides: more fields means keep filling, none means mark used. An abandoned finishing identity is marked used after the 30 min idle timeout.src/main/siteKey.js: one registrable-domain rule for the vault filter and the active-identity store. Shared hosting (myshopify.com, github.io, vercel.app, ...) stays per owner.finishop too (ships after the extension is re-signed; an older extension keeps the old mark-on-submit rule).Verified
npm test: 654 pass.