Repository navigation
Firefox autofill extension 1.0.1: clean add-on lint, no innerHTML - #16
Merged
Merged
Conversation
- Bump the extension to 1.0.1 so it can be signed again (AMO never re-signs a version) and ship the Data Vault fixes to Firefox profiles. - strict_min_version 109 -> 142: data_collection_permissions is only supported from Firefox 140 (Android 142); the bundled Firefox is 150+. - Build the widget's Shadow-DOM markup with DOM calls instead of innerHTML (static markup, but web-ext lint flags any innerHTML assignment). web-ext lint: 0 errors, 0 warnings, 0 notices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the Firefox Smart Autofill extension for re-signing so Firefox profiles get the Data Vault fixes from #15.
.xpiis still the 1.0.0 build from before Fix Data Vault autofill and keep identities active across multi-step signups #15.strict_min_version109 -> 142.data_collection_permissionsis supported from Firefox 140 (Android 142);web-ext lintwarned about both. The app bundles Firefox 150+.innerHTML(the markup is static, but the add-on linter flags anyinnerHTMLassignment). Same source drives the Chromium widget.web-ext lint: 0 errors, 0 warnings, 0 notices.npm test: 648/648. The 3-step signup harness passes unchanged on Chromium.Merge after
npm run sign:firefox-extproduces the signed 1.0.1.xpi.