Repository navigation
Support marshmallow 4 - #64
Merged
Merged
Conversation
Switch to marshmallow>=4.0.0 and marshmallow-jsonapi-minfork. Marshmallow 4 raises TypeError instead of AttributeError when serializing invalid data, so catch TypeError in resource GET handlers to keep returning JSON:API errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marshmallowto>=4.0.0and switch frommarshmallow_jsonapitomarshmallow-jsonapi-minfork.TypeErrorinResourceList.get/ResourceDetail.get: marshmallow 4'sDateTimeserialization raisesTypeError(instead ofAttributeError) on invalid data, which previously escaped and produced Flask's HTML 500 page instead of a JSON:API error.test_bad_data_get_list/test_bad_data_get_detailto not depend on the exact exception message.1.5.0.dev0), since requiring marshmallow 4 and swapping the jsonapi package may break existing users.Test plan
pytest .with marshmallow 4.3.1, marshmallow-jsonapi-minfork 0.26.0, Flask 3.1.3, SQLAlchemy 2.1.6 on Python 3.14: 135 passed.🤖 Generated with Claude Code