chore: Use context.Context from InvocationContext#578
Open
PeterSchafer wants to merge 1 commit intomainfrom
Open
chore: Use context.Context from InvocationContext#578PeterSchafer wants to merge 1 commit intomainfrom
PeterSchafer wants to merge 1 commit intomainfrom
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
dbf05e3 to
9a1e027
Compare
9 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
58f300c to
85d19c3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0212397 to
54f50e9
Compare
This comment has been minimized.
This comment has been minimized.
54f50e9 to
5fc0ff8
Compare
This comment has been minimized.
This comment has been minimized.
d8b965b to
dd5cd9e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4a70373 to
49f15ef
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
49f15ef to
f40d778
Compare
PR Reviewer Guide 🔍
|
danskmt
reviewed
Apr 20, 2026
Comment on lines
-69
to
71
| settings, err := apiClient.GetOrgSettings(org) | ||
| settings, err := apiClient.GetOrgSettings(context.Background(), org) | ||
| if err != nil { |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR includes a couple of refactorings to make use of the context.Context instance provided by the InvocationContext. This requires extending a couple of interfaces.
To keep the changes incremental, it doesn't yet fully use the context and needs to fallback to context.Background() where the context is not directly available yet.
Checklist
make test)make generate)make lint)go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMITin thecliv2directory.go.modto point to your local GAF code.go mod tidyin thecliv2directory.go.modandgo.sumchanges.