Repository navigation
[DPS-XXXX] Event spec validation metrics - #1947
Conversation
Missing SEO metadataThe following markdown files are missing required metadata fields:
Required fieldsThe file metadata is important for SEO and marketing. All markdown files, except for those with filenames starting with
Please add the missing metadata. |
Style reviewSolid, well-structured addition overall: the new A few things worth fixing. 1. Garden-path sentence and past tense in the category intro
The reader hits "the pipeline associated" and expects "associated X with Y", so the sentence has to be re-parsed. The past tense also conflicts with the style guide's "stay in the present tense" rule. Suggest:
2. Non-parallel list of the four categories
"were valid, inferred, had violations" breaks the parallel — "were" doesn't carry over to "had violations". Suggest "were valid or inferred, had violations, or failed" in both places. 3. Category names are inconsistent across the PRThe new page establishes the canonical set: "valid events, inferred events, events with violations, and failed events". Several other places shorten it differently, e.g.
This mixes adjectives and nouns ("violations ... events"). The same shortened form appears in the release note description and in a couple of the new alt texts. Where the full names don't fit, "split by category" plus the link to the data quality page reads better than a half-abbreviated list. Worth picking one form and using it everywhere. 4. "decides" and "Failed events counts"
A button doesn't decide; "controls whether" or "determines whether" is more precise. Also 5. Event Catalog
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
documentation | 467f9db | Commit Preview URL Branch Preview URL |
Sep 22 2026, 08:27 AM |
|
|
||
| Failed event counts come from your [data quality dashboard](/docs/monitoring/index.md), not from the Console API. They are available when the selected pipeline loads failed events into your warehouse, the data quality dashboard is connected to that pipeline, and you have permission to view it. Otherwise the failed events category shows N/A, volumes exclude failed events, and a warning icon next to the volume explains why. | ||
|
|
||
| ## View data quality for a tracking plan |
There was a problem hiding this comment.
tracking plan => Tracking Plan
please double check in other parts too
There was a problem hiding this comment.
Actually no, we call them lower case. I prefer the entities to be capitalized, but this is not what we are doing in general
There was a problem hiding this comment.
look here please "What is a Tracking Plan"
There was a problem hiding this comment.
ok I checked more probably the example I provided should be changed too to lower case... anyway, maybe claude can do it for us
Simone Poggiali at Snowplow.io (gibbok-snowplow)
left a comment
There was a problem hiding this comment.
LGTM, I approve so I do not block you, but fix (if not done ready)
warning:
Missing SEO metadata
plus revise the capitalization in the headers to make it consistent with the rest
I've addressed it already |
I think it already is consistent with the CLAUDE.md
|
No description provided.