Make transformers not throw an error when receiving an empty resutls file - #1068
Open
northdpole wants to merge 33 commits into
Open
Make transformers not throw an error when receiving an empty resutls file#1068northdpole wants to merge 33 commits into
northdpole wants to merge 33 commits into
Conversation
northdpole
marked this pull request as draft
August 19, 2025 23:20
northdpole
force-pushed
the
make-scanners-not-exit-on-0-findings
branch
from
August 20, 2025 07:27
94c9fc4 to
4b12f17
Compare
northdpole
marked this pull request as ready for review
August 20, 2025 07:36
ptzianos
reviewed
Aug 27, 2025
| ctx := context.WithValue(ctx, component.SCANNER_TARGET_METADATA_CTX_KEY, &ocsffindinginfo.DataSource{ | ||
| TargetType: ocsffindinginfo.DataSource_TARGET_TYPE_WEBSITE, | ||
| }) | ||
| ctx, cancel := context.WithCancel(ctx) |
Contributor
There was a problem hiding this comment.
this context should have a timeout, same goes for other contexts used in these tests
Contributor
|
@northdpole how do we test that these components will produce an empty results file if they run and they don't discover anything? or we sure that it's the binaries' behaviour? can we document that somewhere? |
northdpole
force-pushed
the
make-scanners-not-exit-on-0-findings
branch
3 times, most recently
from
August 28, 2025 17:57
859e15a to
bac1f27
Compare
Contributor
Author
|
northdpole
force-pushed
the
make-scanners-not-exit-on-0-findings
branch
2 times, most recently
from
August 28, 2025 20:15
305a652 to
f2d8429
Compare
northdpole
force-pushed
the
make-scanners-not-exit-on-0-findings
branch
2 times, most recently
from
August 28, 2025 23:09
aa341e3 to
1f6c82b
Compare
northdpole
force-pushed
the
make-scanners-not-exit-on-0-findings
branch
from
August 29, 2025 00:10
1f6c82b to
7230277
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.