Add a simple CI#39
Open
jklymak wants to merge 5 commits into
Open
Conversation
Contributor
Author
|
Note I'm getting the Mac-os errors locally as well on my Mac. Not sure about the windows ones. The 3.10 is the fact that python 3.10 |
Contributor
Author
|
PR now bumps python to 3.11. |
Contributor
Author
|
OK, this adds a fix for macOS. Not 100% sure it's correct, but macOS you can't just overwrite an existing file. |
Contributor
Author
|
OK and a couple of windows fixes. |
Contributor
Author
|
@smerckel if you do not want CI, consider the other two changes, but I think CI is pretty useful (unless you have a bunch of machines!) |
Owner
|
CI is fine. I will review the commits one of these days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds a simple CI that will run the tests and build the docs for pull requests.
OK it also makes some Mac and windows compatibility fixes.
Bumps python to 3.11 since
date time.UTCrequires that.