Make compatible with Rails 3.2.22 - #8
Open
vollnhals wants to merge 1 commit into
Open
Conversation
Owner
|
Looks like this is breaking Rails 4. I haven't been using/maintaining this gem actively. This was originally written for Rails 2, then upgraded to Rails 3. You should try using an older version of the gem to address your issue. I'm happy to accept a PR that makes this compatible with Rails 3 & 4, but please make sure the travis build tests all configurations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using preload_counts in rails 3.2.22 project.
Sadly it was not working because of two issues:
allis not lazy and so its not possible to callall.scoped. switch toscopedinsteadscope. check withrespond_to?before callingI have not checked these changes with rails 4.