Repository navigation
restore confidential workflows mixed-env test - #24243
Merged
Merged
Conversation
Re-add Test_CRE_V2_ConfidentialWorkflows_Relay to the mixed-env matrix. It was dropped in #23707 to unblock the merge queue after a chainlink-common bump made it fail; the confidential relay's DON2DON GetSecrets path is now covered by the cross-version gate again. Co-Authored-By: Claude Code <noreply@anthropic.com>
product-security-plaid-production
Bot
requested review from
erikburt and
kalverra
November 19, 2026 21:46
Contributor
|
👋 vreff, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
prashantkumar1982
approved these changes
Nov 19, 2026
vreff
enabled auto-merge
November 19, 2026 22:12
justinkaseman
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds
Test_CRE_V2_ConfidentialWorkflows_Relayto the CRE mixed-env matrix (defaultCREMixedEnvTests).The test was dropped from mixed-env in #23707 (Sept 10) to unblock the merge queue after it failed during a chainlink-common bump. Its per-test topology (
configs/mixed-env-confidential-workflows.toml) and all the confidential-only workflow wiring — chainlink-confidential-compute checkout at the plugin gitRef, fake-enclave prebuild, gateway ports 8080–8083,IS_CONFIDENTIAL_TEST— were left in place, so the matrix entry was the only missing piece.Mixed-env now gates the confidential relay's DON2DON
GetSecretspath again: 2 nodes on the PR image and 2 on the baseline image per DON, with the non-determinism scan failing the job on any marker.Changes
tools/ci/internal/matrix/mixedenv.go: add the test todefaultCREMixedEnvTestscore/scripts/cre/environment/docs/mixed-env.md: document the confidential leg under "When it runs"Testing
go test ./internal/matrix/...andgo test ./cmd/... -run TestMatrixpass in thetools/cimodule🤖 Generated with Claude Code