Repository navigation
(test): Add vault OCR fuzzing - #24242
Open
justinkaseman wants to merge 2 commits into
Open
justinkaseman wants to merge 2 commits into
justinkaseman wants to merge 2 commits into
Conversation
product-security-plaid-production
Bot
requested review from
russell-stern and
vyzaldysanchez
November 19, 2026 19:37
Contributor
|
👋 justinkaseman, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fuzz tests can crash in an empty blob-fetcher test double and incorrectly accept unhealthy shard-0 routing, undermining their ability to detect plugin defects.
2 open issues
What changed in this PR
Adds fuzz tests for the vault and ring OCR plugins, checking deterministic processing and key outcome invariants.
Changes:
- Exercises vault state transitions across oracles with varied requests, stored state, and Byzantine observations.
- Checks ring routing health, state progression, and outcome/report determinism.
- Adds seeded inputs for malformed observations and transition states.
| File | Description |
|---|---|
core/services/ring/plugin_fuzz_test.go |
Adds outcome-invariant and observation-validation fuzz targets. |
core/services/ocr2/plugins/vault/plugin_fuzz_test.go |
Adds cross-oracle state-transition and report-determinism fuzzing. |
Review effort: Balanced
justinkaseman
force-pushed
the
CRE-6953
branch
from
November 19, 2026 21:02
e2f0c2e to
f4dab7e
Compare
justinkaseman
enabled auto-merge
November 19, 2026 22:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.