Skip to content

(test): Add vault OCR fuzzing - #24242

Open
justinkaseman wants to merge 2 commits into
developfrom
CRE-6953
Open

justinkaseman wants to merge 2 commits into
developfrom
CRE-6953

Conversation

@justinkaseman

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

👋 justinkaseman, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The fuzz tests can crash in an empty blob-fetcher test double and incorrectly accept unhealthy shard-0 routing, undermining their ability to detect plugin defects.

2 open issues
What changed in this PR

Adds fuzz tests for the vault and ring OCR plugins, checking deterministic processing and key outcome invariants.

Changes:

  • Exercises vault state transitions across oracles with varied requests, stored state, and Byzantine observations.
  • Checks ring routing health, state progression, and outcome/report determinism.
  • Adds seeded inputs for malformed observations and transition states.
File Description
core/​services/​ring/​plugin_fuzz_test.go Adds outcome-invariant and observation-validation fuzz targets.
core/​services/​ocr2/​plugins/​vault/​plugin_fuzz_test.go Adds cross-oracle state-transition and report-determinism fuzzing.

Review effort: Balanced

Comment thread core/services/ring/plugin_fuzz_test.go Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants