Skip to content

deployment: keep NOPs views when one node has malformed metadata - #24241

Draft
bolekk wants to merge 1 commit into
developfrom
cre-nops-view-skip-bad-nodes
Draft

bolekk wants to merge 1 commit into
developfrom
cre-nops-view-skip-bad-nodes

Conversation

@bolekk

@bolekk bolekk commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

One staging node exported its JD chain ID as "11155111 ethereum-testnet-sepolia". NodeInfo returned a non-ErrMissingNodeMetadata error for it, so GenerateNopsView and GenerateNOPsViewV2 discarded all ~70 nodes, and the CLD nightly job committed a staging state.json without nops/nops_v2 (CLD commit 496134e).

The views now continue with the node list NodeInfo returns and log a warning, so only the bad node loses its chain-derived fields. They still fail when NodeInfo returns no nodes. NodeInfo itself is unchanged, so changesets that need complete node metadata still fail hard.

Related CLD safety net: smartcontractkit/chainlink-deployments#21784.

Deployment Validation: Next CLD nightly state runs keep nops/nops_v2 populated when a node has malformed JD chain config.

🤖 Generated with Claude Code

A single node with an unparsable JD chain ID made NodeInfo return a
non-ErrMissingNodeMetadata error, so GenerateNopsView and
GenerateNOPsViewV2 discarded every node. Continue with the partial
node list instead and log a warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant