Repository navigation
Lower MaxResultsPerQuery to 250 so getWorkflowListByDON fits under RPC gas caps - #24229
Conversation
|
👋 george-dorin, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
|
I see you updated files related to
|
| // getWorkflowListByDON costs roughly 50k gas per returned workflow, so the page size must keep a | ||
| // single eth_call well under the RPC node's gas cap (commonly 16,777,216). At 1,000 the call needs | ||
| // >30M gas once ~600 workflows are indexed and is rejected outright; 250 keeps a page around 12.5M. | ||
| MaxResultsPerQuery = int64(250) |
There was a problem hiding this comment.
Hardcoding it isn't the right solution.
We at the least need to change it to a cresetting. But also need to write code to smartly reduce it if gas errors are seen
We are going with hardcoded to get a fix out immediately. The more robust fix can come after being tested thoroughly.
Cherry-picked from develop: - 31bc3d9 - 31bc3d9 (#24229) Landed by https://github.com/smartcontractkit/chainlink-releases/actions/runs/44418307460 Dispatched by @justinkaseman, approved by @justinkaseman @prashantkumar1982
No description provided.